Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b87c33dc authored by Azhara Assanova's avatar Azhara Assanova
Browse files

Change the app compat check for mutable implicit pending intents 

The old check takes the changeID and the UID which will only consider
the minimum targetSDK amongst the packages in that sharedUID. The new
check will specifically target the package which means that other
packages with lower targetSDKs on the sharedUID won't affect it.

Bug: 280435600
Test: atest PendingIntentTest
Test: manually with a lower targetSDK
Test: manually with a debugger as the system_server
Change-Id: Icb3154048660f5891c403ee5037124d3a7b78de3
parent 25812122

services/core/java/com/android/server/am/ActivityManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -5196,7 +5196,7 @@ public class ActivityManagerService extends IActivityManager.Stub 
                            isActivityResultType)) {

                        boolean isChangeEnabled = CompatChanges.isChangeEnabled(

                                        PendingIntent.BLOCK_MUTABLE_IMPLICIT_PENDING_INTENT,

                                        owningUid);

                                        packageName, UserHandle.of(userId));

                        String resolvedType = resolvedTypes == null

                                || i >= resolvedTypes.length ? null : resolvedTypes[i];

                        ActivityManagerUtils.logUnsafeIntentEvent(