Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b87773e5 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove unused InputMethodManagerInternal#isStylusHandwritingAvailable() 

This CL removes an unused internal method

  InputMethodManagerInternal#isStylusHandwritingAvailable(),

which was added recently [1].

Currently we are discussing multiple projects that may affect the
number of active bindings that InputMethodManagerService manages.
Depending on how such discussions go, we may increase or decrease the
number of active IME sessions, and the concent of

  "isStylusHandwritingAvailable"

may need to be multi-user aware for callers within system_server.
Thus it may make more sense to not expose

  InputMethodManagerInternal#isStylusHandwritingAvailable()

until someone actually start using it in system_server.

 [1]: I0c606e94780ae6636585ab36b751fbf6e90a1cbf
      16b29c14

Bug: 228514000
Test: presubmit
Change-Id: Ia6471a097715bb25fdb0a5a1cb82d2c77d4c3024
parent e38985b0

services/core/java/com/android/server/inputmethod/InputMethodManagerInternal.java

+0 −10
Original line number Diff line number Diff line
@@ -74,11 +74,6 @@ public abstract class InputMethodManagerInternal { 
     */

    public abstract List<InputMethodInfo> getEnabledInputMethodListAsUser(@UserIdInt int userId);



    /**

     * Returns {@code true} if currently selected IME supports Stylus handwriting.

     */

    public abstract boolean isStylusHandwritingAvailable();



    /**

     * Called by the Autofill Frameworks to request an {@link InlineSuggestionsRequest} from

     * the input method.
@@ -261,11 +256,6 @@ public abstract class InputMethodManagerInternal { 
                @Override

                public void maybeFinishStylusHandwriting() {

                }



                @Override

                public boolean isStylusHandwritingAvailable() {

                    return false;

                }

            };



    /**

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+0 −5
Original line number Diff line number Diff line
@@ -5658,11 +5658,6 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub 
            mHandler.removeMessages(MSG_FINISH_HANDWRITING);

            mHandler.obtainMessage(MSG_FINISH_HANDWRITING).sendToTarget();

        }



        @Override

        public boolean isStylusHandwritingAvailable() {

            return InputMethodManagerService.this.isStylusHandwritingAvailable();

        }

    }



    @BinderThread