Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b85d6f1a authored by Pablo Gamito's avatar Pablo Gamito
Browse files

Remove fass assertions from tests

Assertions are very flaky, don't provide any immediately useful information in the current state and going to be replace soon anyways

Test: atest FlickerTests
Change-Id: Id8f7649b818237bc16051d808ef46ca875669faa
parent eafc7435
Loading
Loading
Loading
Loading
+0 −18
Original line number Diff line number Diff line
@@ -71,24 +71,6 @@ class EnterPipTest(testSpec: FlickerTestParameter) : PipTransition(testSpec) {
            }
        }

    @FlakyTest
    @Test
    fun runPresubmitAssertion() {
        flickerRule.checkPresubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runPostsubmitAssertion() {
        flickerRule.checkPostsubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runFlakyAssertion() {
        flickerRule.checkFlakyAssertions()
    }

    /** {@inheritDoc}  */
    @FlakyTest(bugId = 206753786)
    @Test
+0 −18
Original line number Diff line number Diff line
@@ -78,24 +78,6 @@ class ExitPipViaIntentTest(testSpec: FlickerTestParameter) : ExitPipToAppTransit
            }
        }

    @FlakyTest
    @Test
    fun runPresubmitAssertion() {
        flickerRule.checkPresubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runPostsubmitAssertion() {
        flickerRule.checkPostsubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runFlakyAssertion() {
        flickerRule.checkFlakyAssertions()
    }

    /** {@inheritDoc}  */
    @FlakyTest(bugId = 206753786)
    @Test
+1 −19
Original line number Diff line number Diff line
@@ -67,24 +67,6 @@ class ExitPipWithDismissButtonTest(testSpec: FlickerTestParameter) : ExitPipTran
            }
        }

    @FlakyTest
    @Test
    fun runPresubmitAssertion() {
        flickerRule.checkPresubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runPostsubmitAssertion() {
        flickerRule.checkPostsubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runFlakyAssertion() {
        flickerRule.checkFlakyAssertions()
    }

    /** {@inheritDoc}  */
    @FlakyTest(bugId = 206753786)
    @Test
+1 −20
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ package com.android.server.wm.flicker.close

import android.app.Instrumentation
import android.platform.test.annotations.Presubmit
import androidx.test.filters.FlakyTest
import androidx.test.platform.app.InstrumentationRegistry
import com.android.server.wm.flicker.FlickerBuilderProvider
import com.android.server.wm.flicker.FlickerTestParameter
@@ -194,22 +193,4 @@ abstract class CloseAppTransition(protected val testSpec: FlickerTestParameter)
    open fun launcherLayerReplacesApp() {
        testSpec.replacesLayer(testApp.component, LAUNCHER_COMPONENT)
    }

    @FlakyTest
    @Test
    fun runPresubmitAssertion() {
        flickerRule.checkPresubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runPostsubmitAssertion() {
        flickerRule.checkPostsubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runFlakyAssertion() {
        flickerRule.checkFlakyAssertions()
    }
}
+1 −19
Original line number Diff line number Diff line
@@ -94,24 +94,6 @@ class ChangeAppRotationTest(
            }
        }

    @FlakyTest
    @Test
    fun runPresubmitAssertion() {
        flickerRule.checkPresubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runPostsubmitAssertion() {
        flickerRule.checkPostsubmitAssertions()
    }

    @FlakyTest
    @Test
    fun runFlakyAssertion() {
        flickerRule.checkFlakyAssertions()
    }

    /**
     * Windows maybe recreated when rotated. Checks that the focus does not change or if it does,
     * focus returns to [testApp]