Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7f7f7e1 authored by Android Build Merger (Role)'s avatar Android Build Merger (Role)
Browse files

[automerger] Check for null-terminator in ResStringPool::string8At am:... 

[automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae9 am: c3d7250b am: e2417e66 am: 0ab4540c am: a3f09769 am: 166aa6e1

Change-Id: I7d51ce90a1c1075e72dbdf6d1436c4ff22e4f85b
parents f61daaa3 166aa6e1

libs/androidfw/ResourceTypes.cpp

+7 −1
Original line number Diff line number Diff line
@@ -807,6 +807,12 @@ const char* ResStringPool::string8At(size_t idx, size_t* outLen) const 
            *outLen = decodeLength(&str);

            size_t encLen = decodeLength(&str);

            if ((uint32_t)(str+encLen-strings) < mStringPoolSize) {

                // Reject malformed (non null-terminated) strings

                if (str[encLen] != 0x00) {

                    ALOGW("Bad string block: string #%d is not null-terminated",

                          (int)idx);

                    return NULL;

                }

              return (const char*)str;

            } else {

                ALOGW("Bad string block: string #%d extends to %d, past end at %d\n",