Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b798b1c4 authored by Daniel Nishi's avatar Daniel Nishi
Browse files

Fix a bug where image apps were double-counted. 

The filter for photos apps includes them as well as the one for "other
apps". This removes them out of other apps.

Change-Id: I56058080b6492c054ea3171addd5ab343769bc9a
Fixes: 65384691
Test: SettingsLib integ test
parent ae1dd84b

packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java

+2 −1
Original line number Diff line number Diff line
@@ -1665,7 +1665,8 @@ public class ApplicationsState { 
                        isCategorized =

                                FILTER_AUDIO.filterApp(entry)

                                        || FILTER_GAMES.filterApp(entry)

                                        || FILTER_MOVIES.filterApp(entry);

                                        || FILTER_MOVIES.filterApp(entry)

                                        || FILTER_PHOTOS.filterApp(entry);

                    }

                    return !isCategorized;

                }

packages/SettingsLib/tests/integ/src/com/android/settingslib/applications/ApplicationsStateTest.java

+7 −0
Original line number Diff line number Diff line
@@ -102,6 +102,13 @@ public class ApplicationsStateTest { 
        assertThat(ApplicationsState.FILTER_OTHER_APPS.filterApp(mEntry)).isFalse();

    }



    @Test

    public void testOtherAppsRejectsImageApp() {

        mEntry.info.category = ApplicationInfo.CATEGORY_IMAGE;



        assertThat(ApplicationsState.FILTER_OTHER_APPS.filterApp(mEntry)).isFalse();

    }



    @Test

    public void testOtherAppsAcceptsDefaultCategory() {

        mEntry.info.category = ApplicationInfo.CATEGORY_UNDEFINED;