Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b659adb3 authored by Felipe Leme's avatar Felipe Leme
Browse files

Fixed AUTOFILL_UI_LATENCY metric. 

This metric was using the RESERVED_FOR_LOGBUILDER_COUNTER and hence was not
being picked up.

Bug: 71863561
Fixes: 72175011

Test: adb shell logcat -b events | grep sysui | grep 1136
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Change-Id: I34f701ff5336a413477fd14172d16d8d1e5403ad
parent ed6f4636

proto/src/metrics_constants.proto

+5 −1
Original line number Diff line number Diff line
@@ -4545,7 +4545,8 @@ message MetricsEvent { 
    // OS: O MR

    AUTOFILL_SERVICE_DISABLED_SELF = 1135;



    // Counter showing how long it took (in ms) to show the autofill UI after a field was focused

    // Reports how long it took to show the autofill UI after a field was focused

    // Tag FIELD_AUTOFILL_DURATION: Duration in ms

    // Tag FIELD_AUTOFILL_SERVICE: Package of service that processed the request

    // Package: Package of the autofill service

    // OS: O MR
@@ -4584,6 +4585,9 @@ message MetricsEvent { 
    // logged when we cancel an app transition.

    APP_TRANSITION_CANCELLED = 1144;



    // Tag of a field representing a duration on autofill-related metrics.

    FIELD_AUTOFILL_DURATION = 1145;



    // ---- End O-MR1 Constants, all O-MR1 constants go above this line ----



    // Add new aosp constants above this line.

services/autofill/java/com/android/server/autofill/Session.java

+1 −1
Original line number Diff line number Diff line
@@ -1397,7 +1397,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
                mUiLatencyHistory.log(historyLog.toString());



                final LogMaker metricsLog = newLogMaker(MetricsEvent.AUTOFILL_UI_LATENCY)

                        .setCounterValue((int) duration);

                        .addTaggedData(MetricsEvent.FIELD_AUTOFILL_DURATION, duration);

                mMetricsLogger.write(metricsLog);

            }

        }