Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b60583c3 authored by Eric Biggers's avatar Eric Biggers
Browse files

Log errors in verifyChallengeInternal() 

It is unexpected for verifyChallengeInternal() to fail, since the
Gatekeeper enrollment of the synthetic password (more specifically, the
Gatekeeper password derived from the synthetic password) should always
be valid.  Therefore, ensure that an error message is logged in all
failure cases.

Bug: 282947979
Change-Id: Ic8d0134bc4f3e0979bf500ffb5a99f2522251d39
parent ed2a0e33

services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java

+2 −0
Original line number Original line Diff line number Diff line
@@ -1567,8 +1567,10 @@ class SyntheticPasswordManager { 
            }

            }

            return result;

            return result;

        } else if (responseCode == GateKeeperResponse.RESPONSE_RETRY) {

        } else if (responseCode == GateKeeperResponse.RESPONSE_RETRY) {

            Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_RETRY");

            return VerifyCredentialResponse.fromTimeout(response.getTimeout());

            return VerifyCredentialResponse.fromTimeout(response.getTimeout());

        } else {

        } else {

            Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_ERROR");

            return VerifyCredentialResponse.ERROR;

            return VerifyCredentialResponse.ERROR;

        }

        }

    }

    }