Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5ea1693 authored by Tom Cherry's avatar Tom Cherry
Browse files

Do not synthesize events for relative mouse movement. 

If apps opt into relative mouse movement they must be prepared to
handle the events.

Bug: 268243026
Test: no synthetic key events are generated by an app with mouse
      capture that does not mark its events as handled.
Change-Id: I591c0036801473032d5e34a4c9ca3c1fd6215761
parent 9f16957b

core/java/android/view/ViewRootImpl.java

+5 −1
Original line number Diff line number Diff line
@@ -7072,7 +7072,11 @@ public final class ViewRootImpl implements ViewParent, 
                final MotionEvent event = (MotionEvent)q.mEvent;

                final int source = event.getSource();

                if ((source & InputDevice.SOURCE_CLASS_TRACKBALL) != 0) {

                    // Do not synthesize events for relative mouse movement. If apps opt into

                    // relative mouse movement they must be prepared to handle the events.

                    if (!event.isFromSource(InputDevice.SOURCE_MOUSE_RELATIVE)) {

                        mTrackball.process(event);

                    }

                    return FINISH_HANDLED;

                } else if ((source & InputDevice.SOURCE_CLASS_JOYSTICK) != 0) {

                    mJoystick.process(event);