Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5e5053e authored by Lucas Dupin's avatar Lucas Dupin
Browse files

Revert "WallpaperColors hint computation" 

This reverts commit c50f47d9.

Fixes: 79465234
Reason for revert: Google still does it using private APIs and apps were relying on this behavior, not good for the ecosystem.

Change-Id: I62e2b4cd1e6e562fcdd89c97e599bcdade83381a
parent c50f47d9

core/java/android/app/WallpaperColors.java

+1 −8
Original line number Diff line number Diff line
@@ -137,13 +137,6 @@ public final class WallpaperColors implements Parcelable { 
     * @param bitmap Source where to extract from.

     */

    public static WallpaperColors fromBitmap(@NonNull Bitmap bitmap) {

        return fromBitmap(bitmap, false /* computeHints */);

    }



    /**

     * @hide

     */

    public static WallpaperColors fromBitmap(@NonNull Bitmap bitmap, boolean computeHints) {

        if (bitmap == null) {

            throw new IllegalArgumentException("Bitmap can't be null");

        }
@@ -193,7 +186,7 @@ public final class WallpaperColors implements Parcelable { 
            }

        }



        int hints = computeHints ? calculateDarkHints(bitmap) : 0;

        int hints = calculateDarkHints(bitmap);



        if (shouldRecycle) {

            bitmap.recycle();

services/core/java/com/android/server/wallpaper/WallpaperManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -458,7 +458,7 @@ public class WallpaperManagerService extends IWallpaperManager.Stub 
        if (cropFile != null) {

            Bitmap bitmap = BitmapFactory.decodeFile(cropFile);

            if (bitmap != null) {

                colors = WallpaperColors.fromBitmap(bitmap, true /* computeHints */);

                colors = WallpaperColors.fromBitmap(bitmap);

                bitmap.recycle();

            }

        }

services/tests/servicestests/src/com/android/server/wallpaper/WallpaperServiceTests.java

+0 −15
Original line number Diff line number Diff line
@@ -20,8 +20,6 @@ import static org.junit.Assert.assertEquals; 
import static org.junit.Assert.assertTrue;



import android.app.WallpaperColors;

import android.graphics.Color;

import android.graphics.drawable.ColorDrawable;

import android.os.Handler;

import android.os.Message;

import android.os.SystemClock;
@@ -87,17 +85,4 @@ public class WallpaperServiceTests { 
        assertEquals("OnComputeColors should have been deferred.",

                0, eventCountdown.getCount());

    }



    @Test

    public void testFromDrawableTest_doesntComputeHints() {

        WallpaperColors wallpaperColors = WallpaperColors.fromDrawable(

                new ColorDrawable(Color.BLACK));

        assertEquals("WallpaperColors should not support dark theme.", 0,

                wallpaperColors.getColorHints() & WallpaperColors.HINT_SUPPORTS_DARK_THEME);



        wallpaperColors = WallpaperColors.fromDrawable(

                new ColorDrawable(Color.WHITE));

        assertEquals("WallpaperColors should not support dark text.", 0,

                wallpaperColors.getColorHints() & WallpaperColors.HINT_SUPPORTS_DARK_TEXT);

    }

}