Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b587f505 authored by Joshua Mccloskey's avatar Joshua Mccloskey
Browse files

Revert "Finish FaceAuthClient onLockout" 

This reverts commit 9f26c90f.

Reason for revert: Going to push into d1-dev for more soak time

Change-Id: I9151084a896d0cbd7a714104d6ebab60609dba6b
(cherry picked from commit bebffbf3)
parent 451c9ea0

services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceAuthenticationClient.java

+10 −4
Original line number Diff line number Diff line
@@ -212,8 +212,6 @@ class FaceAuthenticationClient extends AuthenticationClient<AidlSession, FaceAut 
        // 1) Authenticated == true

        // 2) Error occurred

        // 3) Authenticated == false

        // 4) onLockout

        // 5) onLockoutTimed

        mCallback.onClientFinished(this, true /* success */);

    }
@@ -306,7 +304,11 @@ class FaceAuthenticationClient extends AuthenticationClient<AidlSession, FaceAut 
        PerformanceTracker.getInstanceForSensorId(getSensorId())

                .incrementTimedLockoutForUser(getTargetUserId());



        onError(error, 0 /* vendorCode */);

        try {

            getListener().onError(getSensorId(), getCookie(), error, 0 /* vendorCode */);

        } catch (RemoteException e) {

            Slog.e(TAG, "Remote exception", e);

        }

    }



    @Override
@@ -321,6 +323,10 @@ class FaceAuthenticationClient extends AuthenticationClient<AidlSession, FaceAut 
        PerformanceTracker.getInstanceForSensorId(getSensorId())

                .incrementPermanentLockoutForUser(getTargetUserId());



        onError(error, 0 /* vendorCode */);

        try {

            getListener().onError(getSensorId(), getCookie(), error, 0 /* vendorCode */);

        } catch (RemoteException e) {

            Slog.e(TAG, "Remote exception", e);

        }

    }

}

services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceProvider.java

+1 −1
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ public class FaceProvider implements IBinder.DeathRecipient, ServiceProvider { 
                        BaseClientMonitor clientMonitor,

                        boolean success) {

                    mAuthSessionCoordinator.authEndedFor(userId, Utils.getCurrentStrength(sensorId),

                            sensorId, requestId, client.wasAuthSuccessful());

                            sensorId, requestId, success);

                }

            });

        });

services/tests/servicestests/src/com/android/server/biometrics/sensors/face/aidl/FaceAuthenticationClientTest.java

+0 −22
Original line number Diff line number Diff line
@@ -149,28 +149,6 @@ public class FaceAuthenticationClientTest { 
        verify(mHal, never()).authenticate(anyLong());

    }



    @Test

    public void testLockoutEndsOperation() throws RemoteException {

        final FaceAuthenticationClient client = createClient(2);

        client.start(mCallback);

        client.onLockoutPermanent();



        verify(mClientMonitorCallbackConverter).onError(anyInt(), anyInt(),

                eq(FACE_ERROR_LOCKOUT_PERMANENT), anyInt());

        verify(mCallback).onClientFinished(client, false);

    }



    @Test

    public void testTemporaryLockoutEndsOperation() throws RemoteException {

        final FaceAuthenticationClient client = createClient(2);

        client.start(mCallback);

        client.onLockoutTimed(1000);



        verify(mClientMonitorCallbackConverter).onError(anyInt(), anyInt(),

                eq(FACE_ERROR_LOCKOUT), anyInt());

        verify(mCallback).onClientFinished(client, false);

    }



    @Test

    public void notifyHalWhenContextChanges() throws RemoteException {

        final FaceAuthenticationClient client = createClient();