Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b57f32e6 authored by Treehugger Robot's avatar Treehugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Simplify synchronized code and add comments" am: 9791b54b 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1416212

Change-Id: I9024a3daf944ebeeb7d2c179f51f42b1c62563a9
parents b11b8ec3 9791b54b

media/java/android/media/AudioSystem.java

+8 −9
Original line number Diff line number Diff line
@@ -304,6 +304,7 @@ public class AudioSystem 
    /** @hide Media server died. see ErrorCallback */

    public static final int AUDIO_STATUS_SERVER_DIED = 100;



    // all accesses must be synchronized (AudioSystem.class)

    private static ErrorCallback sErrorCallback;



    /** @hide
@@ -340,12 +341,10 @@ public class AudioSystem 
    @UnsupportedAppUsage

    private static void errorCallbackFromNative(int error)

    {

        ErrorCallback errorCallback = null;

        ErrorCallback errorCallback;

        synchronized (AudioSystem.class) {

            if (sErrorCallback != null) {

            errorCallback = sErrorCallback;

        }

        }

        if (errorCallback != null) {

            errorCallback.onError(error);

        }
@@ -364,6 +363,7 @@ public class AudioSystem 
    //keep in sync with include/media/AudioPolicy.h

    private final static int DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE = 0;



    // all accesses must be synchronized (AudioSystem.class)

    private static DynamicPolicyCallback sDynPolicyCallback;



    /** @hide */
@@ -378,12 +378,10 @@ public class AudioSystem 
    @UnsupportedAppUsage

    private static void dynamicPolicyCallbackFromNative(int event, String regId, int val)

    {

        DynamicPolicyCallback cb = null;

        DynamicPolicyCallback cb;

        synchronized (AudioSystem.class) {

            if (sDynPolicyCallback != null) {

            cb = sDynPolicyCallback;

        }

        }

        if (cb != null) {

            switch(event) {

                case DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE:
@@ -426,6 +424,7 @@ public class AudioSystem 
                        int activeSource, String packName);

    }



    // all accesses must be synchronized (AudioSystem.class)

    private static AudioRecordingCallback sRecordingCallback;



    /** @hide */
@@ -458,7 +457,7 @@ public class AudioSystem 
                          int source, int portId, boolean silenced, int[] recordingFormat,

                          AudioEffect.Descriptor[] clientEffects, AudioEffect.Descriptor[] effects,

                          int activeSource) {

        AudioRecordingCallback cb = null;

        AudioRecordingCallback cb;

        synchronized (AudioSystem.class) {

            cb = sRecordingCallback;

        }