Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5021768 authored by Yining Liu's avatar Yining Liu
Browse files

Add aconfig flag for fixing the transparent group header 

Add aconfig flag for fixing the transparent group header issue when the
 async header inflation is enabled, dark mode just changed, and the
 group is automate-generated.

Bug: 340161724
Test: n/a
Flag: com.android.systemui.notification_transparent_header_fix
Change-Id: Iaf1a59e047b1a284fdd4f50be7811c519a48bac9
parent 590199f5

packages/SystemUI/aconfig/systemui.aconfig

+10 −0
Original line number Diff line number Diff line
@@ -145,6 +145,16 @@ flag { 
    bug: "325936094"

}



flag {

   name: "notification_transparent_header_fix"

   namespace: "systemui"

   description: "fix the transparent group header issue for async header inflation."

   bug: "340161724"

   metadata {

        purpose: PURPOSE_BUGFIX

   }

}



flag {

   name: "pss_app_selector_abrupt_exit_fix"

   namespace: "systemui"

packages/SystemUI/src/com/android/systemui/statusbar/notification/shared/TransparentHeaderFix.kt

0 → 100644
+53 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2024 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.systemui.statusbar.notification.shared



import com.android.systemui.Flags

import com.android.systemui.flags.FlagToken

import com.android.systemui.flags.RefactorFlagUtils



/** Helper for reading or using the notification transparent header fix flag state. */

@Suppress("NOTHING_TO_INLINE")

object TransparentHeaderFix {

    /** The aconfig flag name */

    const val FLAG_NAME = Flags.FLAG_NOTIFICATION_TRANSPARENT_HEADER_FIX



    /** A token used for dependency declaration */

    val token: FlagToken

        get() = FlagToken(FLAG_NAME, isEnabled)



    /** Is the flag enabled */

    @JvmStatic

    inline val isEnabled

        get() = Flags.notificationTransparentHeaderFix()



    /**

     * Called to ensure code is only run when the flag is enabled. This protects users from the

     * unintended behaviors caused by accidentally running new logic, while also crashing on an eng

     * build to ensure that the refactor author catches issues in testing.

     */

    @JvmStatic

    inline fun isUnexpectedlyInLegacyMode() =

        RefactorFlagUtils.isUnexpectedlyInLegacyMode(isEnabled, FLAG_NAME)



    /**

     * Called to ensure code is only run when the flag is disabled. This will throw an exception if

     * the flag is enabled to ensure that the refactor author catches issues in testing.

     */

    @JvmStatic

    inline fun assertInLegacyMode() = RefactorFlagUtils.assertInLegacyMode(isEnabled, FLAG_NAME)

}