Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b48d4d10 authored by John Reck's avatar John Reck
Browse files

CTS of CtsMediaTestCases#android.media.cts.DecodeAccuracyTest may fail when video is cropped. 


When we use GPU to copy the data, rendering would choose filter. But we need add shrink in border to ensure the sampler not reach border like what GUI does.

Change-Id: I2c59956f3d7a7052d8e4bee587360f252a6c5549
Signed-off-by: default avatarChun Jiang <chun.jiang@mediatek.com>
Bug: 197180327
Test: CTS PixelCopyTests & DecodeAccuracyTest
parent cbe9af5a

libs/hwui/Readback.cpp

+16 −0
Original line number Diff line number Diff line
@@ -32,6 +32,8 @@ 


using namespace android::uirenderer::renderthread;



static constexpr bool sEnableExtraCropInset = true;



namespace android {

namespace uirenderer {
@@ -71,6 +73,20 @@ CopyResult Readback::copySurfaceInto(ANativeWindow* window, const Rect& inSrcRec 
        ALOGW("Surface doesn't have any previously queued frames, nothing to readback from");

        return CopyResult::SourceEmpty;

    }



    if (sEnableExtraCropInset &&

        (cropRect.right - cropRect.left != bitmap->width() ||

        cropRect.bottom - cropRect.top != bitmap->height())) {

       /*

        * When we need use filtering, we should also make border shrink here like gui.

        * But we could not check format for YUV or RGB here... Just use 1 pix.

        */

        cropRect.left += 0.5f;

        cropRect.top  += 0.5f;

        cropRect.right -= 0.5f;

        cropRect.bottom -= 0.5f;

    }



    UniqueAHardwareBuffer sourceBuffer{rawSourceBuffer};

    AHardwareBuffer_Desc description;

    AHardwareBuffer_describe(sourceBuffer.get(), &description);