Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b40a9a47 authored by Amith Yamasani's avatar Amith Yamasani
Browse files

Rate limit calls to AM.getProcessesInErrorState 

Allow upto 200 calls per second and return cached
value if called at a higher rate.

Bug: 361146083
Test: Take a trace when running an app that calls periodically
Flag: android.app.rate_limit_get_processes_in_error_state

Change-Id: Ia7498070987a352c85e3a0d8cd326b246d8db406
parent e0838caa

core/java/android/app/ActivityManager.java

+14 −0
Original line number Diff line number Diff line
@@ -233,6 +233,10 @@ public class ActivityManager { 
    private static final RateLimitingCache<List<RunningAppProcessInfo>> mRunningProcessesCache =

            new RateLimitingCache<>(10, 4);



    /** Rate-Limiting Cache that allows no more than 200 calls to the service per second. */

    private static final RateLimitingCache<List<ProcessErrorStateInfo>> mErrorProcessesCache =

            new RateLimitingCache<>(10, 2);



    /**

     * Map of callbacks that have registered for {@link UidFrozenStateChanged} events.

     * Will be called when a Uid has become frozen or unfrozen.
@@ -3685,6 +3689,16 @@ public class ActivityManager { 
     * specified.

     */

    public List<ProcessErrorStateInfo> getProcessesInErrorState() {

        if (Flags.rateLimitGetProcessesInErrorState()) {

            return mErrorProcessesCache.get(() -> {

                return getProcessesInErrorStateInternal();

            });

        } else {

            return getProcessesInErrorStateInternal();

        }

    }



    private List<ProcessErrorStateInfo> getProcessesInErrorStateInternal() {

        try {

            return getService().getProcessesInErrorState();

        } catch (RemoteException e) {

core/java/android/app/activity_manager.aconfig

+11 −0
Original line number Diff line number Diff line
@@ -93,3 +93,14 @@ flag { 
     }

}



flag {

     namespace: "backstage_power"

     name: "rate_limit_get_processes_in_error_state"

     description: "Rate limit calls to getProcessesInErrorState using a cache"

     is_fixed_read_only: true

     bug: "361146083"

     metadata {

         purpose: PURPOSE_BUGFIX

     }

}