Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3d70aab authored by Daniel's avatar Daniel
Browse files

unflag cred autofill security fix 

Flag: android.credentials.flags.safeguard_candidate_credentials_api_caller
Bug: 370477460
Test: atest CtsAutoFillServiceTestCases:android.autofillservice.cts.inline.InlineLoginMixedCredentialActivityTest
Change-Id: Ia797afdf1b51c6dc84944b8c91cd39790a1907e3
parent 571a97ad

services/credentials/java/com/android/server/credentials/CredentialManagerService.java

+20 −24
Original line number Diff line number Diff line
@@ -51,7 +51,6 @@ import android.credentials.ISetEnabledProvidersCallback; 
import android.credentials.PrepareGetCredentialResponseInternal;

import android.credentials.RegisterCredentialDescriptionRequest;

import android.credentials.UnregisterCredentialDescriptionRequest;

import android.credentials.flags.Flags;

import android.os.Binder;

import android.os.CancellationSignal;

import android.os.IBinder;
@@ -538,7 +537,6 @@ public final class CredentialManagerService 


            final int userId = UserHandle.getCallingUserId();

            final int callingUid = Binder.getCallingUid();

            if (Flags.safeguardCandidateCredentialsApiCaller()) {

            try {

                String credentialManagerAutofillCompName = mContext.getResources().getString(

                        R.string.config_defaultCredentialManagerAutofillService);
@@ -563,8 +561,6 @@ public final class CredentialManagerService 
                throw new SecurityException(

                        "Credential Autofill service does not exist on this device.");

            }

            }





            // New request session, scoped for this request only.

            final GetCandidateRequestSession session =