Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3b9ceed authored by Devin Taylor's avatar Devin Taylor Committed by Steve Kondik
Browse files

Fix last character of password field being visible after rotation 

This is a fix for http://code.google.com/p/android/issues/detail?id=907. Note that
that issue was declined without comment, but the bug (while incredibly minor)
does exist. This can be seen on the facebook app, as well as many third party apps.

Change-Id: I8f1449c47228f5f757a5baf389656e51c817b150
parent 64657c43

core/java/android/text/method/PasswordTransformationMethod.java

+11 −8
Original line number Diff line number Diff line
@@ -51,6 +51,8 @@ implements TransformationMethod, TextWatcher 
                sp.removeSpan(vr[i]);

            }



            removeVisibleSpans(sp);



            sp.setSpan(new ViewReference(view), 0, 0,

                       Spannable.SPAN_POINT_POINT);

        }
@@ -100,10 +102,7 @@ implements TransformationMethod, TextWatcher 
            int pref = TextKeyListener.getInstance().getPrefs(v.getContext());

            if ((pref & TextKeyListener.SHOW_PASSWORD) != 0) {

                if (count > 0) {

                    Visible[] old = sp.getSpans(0, sp.length(), Visible.class);

                    for (int i = 0; i < old.length; i++) {

                        sp.removeSpan(old[i]);

                    }

                    removeVisibleSpans(sp);



                    if (count == 1) {

                        sp.setSpan(new Visible(sp, this), start, start + count,
@@ -125,13 +124,17 @@ implements TransformationMethod, TextWatcher 
            if (sourceText instanceof Spannable) {

                Spannable sp = (Spannable) sourceText;



                removeVisibleSpans(sp);

            }

        }

    }



    private static void removeVisibleSpans(Spannable sp) {

        Visible[] old = sp.getSpans(0, sp.length(), Visible.class);

        for (int i = 0; i < old.length; i++) {

            sp.removeSpan(old[i]);

        }

    }

        }

    }



    private static class PasswordCharSequence

    implements CharSequence, GetChars