Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b37e1cd8 authored by Bryan Henry's avatar Bryan Henry
Browse files

Revert "Allow shared users to rotate signing certs in an OTA" 

This reverts commit ffd979d6.

Reason for revert: Replacing with go/oag/673735
Bug: 74501739
Test: N/A

Change-Id: I9e87b0f815081a196218744653542a29939c82bb
parent 3577f6df

services/core/java/com/android/server/pm/PackageManagerService.java

+13 −3
Original line number Diff line number Diff line
@@ -10198,10 +10198,20 @@ public class PackageManagerService extends IPackageManager.Stub 
                // The signature has changed, but this package is in the system

                // image...  let's recover!

                pkgSetting.signatures.mSigningDetails = pkg.mSigningDetails;

                // If the system app is part of a shared user we allow that shared user to change

                // signatures as well in part as part of an OTA.

                // However...  if this package is part of a shared user, but it

                // doesn't match the signature of the shared user, let's fail.

                // What this means is that you can't change the signatures

                // associated with an overall shared user, which doesn't seem all

                // that unreasonable.

                if (signatureCheckPs.sharedUser != null) {

                    signatureCheckPs.sharedUser.signatures.mSigningDetails = pkg.mSigningDetails;

                    if (compareSignatures(

                            signatureCheckPs.sharedUser.signatures.mSigningDetails.signatures,

                            pkg.mSigningDetails.signatures) != PackageManager.SIGNATURE_MATCH) {

                        throw new PackageManagerException(

                                INSTALL_PARSE_FAILED_INCONSISTENT_CERTIFICATES,

                                "Signature mismatch for shared user: "

                                        + pkgSetting.sharedUser);

                    }

                }

                // File a report about this.

                String msg = "System package " + pkg.packageName