Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b33444e6 authored by Ioana Alexandru's avatar Ioana Alexandru
Browse files

[Notif redesign] Increase min height of notif 

Both one-line notifications and header-only notifications have the same
height as the small two-line notification now.

Bug: 378660052
Test: visual test, screenshot tests to come later
Flag: android.app.notifications_redesign_templates
Change-Id: I835d947ad3b9c3d418655a16958a60120740b309
parent 42db53c8

core/res/res/layout/notification_2025_template_collapsed_base.xml

+2 −2
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ 
    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:layout_weight="1"

    android:minHeight="@dimen/notification_headerless_min_height"

    android:minHeight="@dimen/notification_2025_min_height"

    android:tag="base"

    >
@@ -81,7 +81,7 @@ 
                android:id="@+id/notification_top_line"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:minHeight="@dimen/notification_headerless_line_height"

                android:minHeight="@dimen/notification_2025_content_min_height"

                android:clipChildren="false"

                android:theme="@style/Theme.DeviceDefault.Notification"

                >

core/res/res/layout/notification_2025_template_collapsed_call.xml

+1 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
        xmlns:android="http://schemas.android.com/apk/res/android"

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:minHeight="88dp"

        android:minHeight="@dimen/notification_2025_min_height"

        android:orientation="horizontal"

        >
@@ -43,7 +43,6 @@ 
            android:layout_weight="1"

            android:layout_marginStart="@dimen/conversation_content_start"

            android:orientation="vertical"

            android:minHeight="68dp"

            android:paddingBottom="@dimen/notification_2025_margin"

            >

core/res/res/layout/notification_2025_template_collapsed_media.xml

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ 
    xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:minHeight="@dimen/notification_min_height"

    android:minHeight="@dimen/notification_2025_min_height"

    android:tag="media"

    >

core/res/res/layout/notification_2025_template_collapsed_messaging.xml

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 
        <com.android.internal.widget.NotificationMaxHeightFrameLayout

            android:layout_width="match_parent"

            android:layout_height="wrap_content"

            android:minHeight="@dimen/notification_min_height"

            android:minHeight="@dimen/notification_2025_min_height"

            android:clipChildren="false"

            >

core/res/res/values/dimens.xml

+11 −2
Original line number Diff line number Diff line
@@ -404,10 +404,19 @@ 
    <!-- The height of each of the 1 or 2 lines in the headerless notification template -->

    <dimen name="notification_headerless_line_height">24dp</dimen>



    <!-- vertical margin for the headerless notification content -->

    <!-- The minimum height of the notification content (even when there's only one line of text) -->

    <dimen name="notification_2025_content_min_height">40dp</dimen>



    <!-- Height of a headerless notification with one or two lines -->

    <!-- 16 * 2 (margins) + 40 (min content height) = 72 (notification) -->

    <dimen name="notification_2025_min_height">72dp</dimen>



    <!-- Height of a headerless notification with one line -->

    <!-- 16 * 2 (margins) + 24 (1 line) = 56 (notification) -->

    <dimen name="notification_headerless_min_height">56dp</dimen>



    <!-- Height of a small notification in the status bar -->

    <!-- Height of a small two-line notification -->

    <!-- 20 * 2 (margins) + 24 * 2 (2 lines) = 88 (notification) -->

    <dimen name="notification_min_height">88dp</dimen>



    <!-- The width of the big icons in notifications. -->