Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b31c0636 authored by Paul Jensen's avatar Paul Jensen
Browse files

Stop logging false error when lingering completes. 

When lingering completes ConnectivityService would log an error message
saying the Network still had NetworkRequests.  Fixed by ignoring
listening NetworkRequests which aren't a problem.

Change-Id: Ie78a1f91c47b012eae28a377dd77bee2cfcbde3b
parent d7063e66

services/core/java/com/android/server/ConnectivityService.java

+7 −3
Original line number Diff line number Diff line
@@ -4436,10 +4436,14 @@ public class ConnectivityService extends IConnectivityManager.Stub { 
            loge("Unknown NetworkAgentInfo in handleLingerComplete");

            return;

        }

        if (DBG) log("handleLingerComplete for " + oldNetwork.name());

        if (DBG) {

            if (oldNetwork.networkRequests.size() != 0) {

                loge("Dead network still had " + oldNetwork.networkRequests.size() + " requests");

            log("handleLingerComplete for " + oldNetwork.name());

            for (int i = 0; i < oldNetwork.networkRequests.size(); i++) {

                NetworkRequest nr = oldNetwork.networkRequests.valueAt(i);

                // Ignore listening requests.

                if (mNetworkRequests.get(nr).isRequest == false) continue;

                loge("Dead network still had at least " + nr);

                break;

            }

        }

        oldNetwork.asyncChannel.disconnect();