Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b26f1462 authored by hukaixiang's avatar hukaixiang
Browse files

Fix: 

avoid the potential attack on SlicePermissionActivity

Bug: 288215072

Analysis:
Third-party apps may pass malformed data, causing getParcelableExtra method to throw an exception.

Change-Id: I9e37728897a31a361af3a183983b646da0918b63
parent 3e77c6f3

packages/SystemUI/src/com/android/systemui/SlicePermissionActivity.java

+5 −1
Original line number Diff line number Diff line
@@ -51,7 +51,11 @@ public class SlicePermissionActivity extends Activity implements OnClickListener 
        super.onCreate(savedInstanceState);



        // Verify intent is valid

        try {

            mUri = getIntent().getParcelableExtra(SliceProvider.EXTRA_BIND_URI);

        } catch (Exception e) {

            Log.w(TAG, "Failed to getParcelableExtra", e);

        }

        mCallingPkg = getIntent().getStringExtra(SliceProvider.EXTRA_PKG);

        if (mUri == null

                || !SliceProvider.SLICE_TYPE.equals(getContentResolver().getType(mUri))