Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b22a6d73 authored by Manjeet Rulhania's avatar Manjeet Rulhania Committed by Android (Google) Code Review
Browse files

Merge "Fix duplicate permission privilege escalation" into qt-dev

parents e7da6dd2 31bd425b

core/java/android/content/pm/PackageParser.java

+53 −0
Original line number Diff line number Diff line
@@ -89,6 +89,7 @@ import android.util.AttributeSet; 
import android.util.Base64;

import android.util.ByteStringUtils;

import android.util.DisplayMetrics;

import android.util.EventLog;

import android.util.Log;

import android.util.PackageUtils;

import android.util.Pair;
@@ -132,6 +133,7 @@ import java.util.Collections; 
import java.util.Comparator;

import java.util.Iterator;

import java.util.List;

import java.util.Objects;

import java.util.Set;

import java.util.UUID;

import java.util.concurrent.atomic.AtomicInteger;
@@ -2501,6 +2503,12 @@ public class PackageParser { 
            }

        }



        if (declareDuplicatePermission(pkg)) {

            outError[0] = "Found duplicate permission with a different attribute value.";

            mParseError = PackageManager.INSTALL_PARSE_FAILED_MANIFEST_MALFORMED;

            return null;

        }



        if (supportsSmallScreens < 0 || (supportsSmallScreens > 0

                && pkg.applicationInfo.targetSdkVersion

                        >= android.os.Build.VERSION_CODES.DONUT)) {
@@ -2540,6 +2548,51 @@ public class PackageParser { 
        return pkg;

    }



    /**

     * @return {@code true} if the package declares malformed duplicate permissions.

     */

    public static boolean declareDuplicatePermission(@NonNull Package pkg) {

        final List<Permission> permissions = pkg.permissions;

        final int size = permissions.size();

        if (size > 0) {

            final ArrayMap<String, Permission> checkDuplicatePerm = new ArrayMap<>(size);

            for (int i = 0; i < size; i++) {

                final Permission permissionDefinition = permissions.get(i);

                final String name = permissionDefinition.info.name;

                final Permission perm = checkDuplicatePerm.get(name);

                if (isMalformedDuplicate(permissionDefinition, perm)) {

                    // Fix for b/213323615

                    EventLog.writeEvent(0x534e4554, "213323615",

                            "The package " + pkg.packageName + " seems malicious");

                    return true;

                }

                checkDuplicatePerm.put(name, permissionDefinition);

            }

        }

        return false;

    }



    /**

     * Determines if a duplicate permission is malformed .i.e. defines different protection level

     * or group.

     */

    private static boolean isMalformedDuplicate(Permission p1, Permission p2) {

        // Since a permission tree is also added as a permission with normal protection

        // level, we need to skip if the parsedPermission is a permission tree.

        if (p1 == null || p2 == null || p1.tree || p2.tree) {

            return false;

        }



        if (p1.info.getProtection() != p2.info.getProtection()) {

            return true;

        }

        if (!Objects.equals(p1.info.group, p2.info.group)) {

            return true;

        }



        return false;

    }



    private boolean checkOverlayRequiredSystemProperty(String propName, String propValue) {



        if (TextUtils.isEmpty(propName) || TextUtils.isEmpty(propValue)) {