Commit b22a6023 authored Mar 09, 2022 by Winson

Null check signature array before comparison

SigningDetails.UNKNOWN is defined with a null array, so if any
package fails to scan signatures, this code would crash with an
NPE.

Instead of failing, just treat it as an empty signature array.

It's unclear what caused this to pop up now, as this code hasn't
changed in a long while.

Bug: 223469467

Test: presubmit

Change-Id: Icdcfaaa3586898873b719c74dd5662b03e3fabae

parent 4359c9d3

core/java/android/content/pm/Signature.java

+2 −2

Original line number	Diff line number	Diff line
		@@ -312,7 +312,7 @@ public class Signature implements Parcelable {
		* @hide
		*/
		public static boolean areExactMatch(Signature[] a, Signature[] b) {
		return (a.length == b.length) && ArrayUtils.containsAll(a, b)
		return (ArrayUtils.size(a) == ArrayUtils.size(b)) && ArrayUtils.containsAll(a, b)
		&& ArrayUtils.containsAll(b, a);
		}