Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1f1209d authored by Narayan Kamath's avatar Narayan Kamath
Browse files

Zygote : Block SIGCHLD during fork. 



We close the android logging related sockets prior as late as possible
before every fork to avoid having to whitelist them. If one of the
zygote's children dies after this point (but prior to the fork), we can
end up reopening the logging sockets from the SIGCHLD signal handler.

To prevent this from happening, block SIGCHLD during this critical
section.

Bug: 32693692
Test: Manual

(cherry picked from commit e9a52582)

Zygote: Unblock SIGCHLD in the parent after fork.

Follow up to change e9a52582. Allows the zygote to
receive SIGCHLD again and prevents the zygote from getting into a
zombie state if it's killed.

Contributed-By: default avatarrhed_jao <rhed_jao@htc.com>
Bug: 32693692
Test: manual

(cherry picked from commit 1480dc3e)

Change-Id: If89903a29c84dfc9b056f9e19618046874bba689
parent 7bd25ab4

core/jni/com_android_internal_os_Zygote.cpp

+25 −0
Original line number Diff line number Diff line
@@ -446,6 +446,20 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra 
  ckTime(start, "ForkAndSpecializeCommon:SetSigChldHandler");





  sigset_t sigchld;

  sigemptyset(&sigchld);

  sigaddset(&sigchld, SIGCHLD);



  // Temporarily block SIGCHLD during forks. The SIGCHLD handler might

  // log, which would result in the logging FDs we close being reopened.

  // This would cause failures because the FDs are not whitelisted.

  //

  // Note that the zygote process is single threaded at this point.

  if (sigprocmask(SIG_BLOCK, &sigchld, NULL) == -1) {

    ALOGE("sigprocmask(SIG_SETMASK, { SIGCHLD }) failed: %s", strerror(errno));

    RuntimeAbort(env, __LINE__, "Call to sigprocmask(SIG_BLOCK, { SIGCHLD }) failed.");

  }



  // Close any logging related FDs before we start evaluating the list of

  // file descriptors.

  __android_log_close();
@@ -479,6 +493,11 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra 
      RuntimeAbort(env, __LINE__, "Unable to reopen whitelisted descriptors.");

    }



    if (sigprocmask(SIG_UNBLOCK, &sigchld, NULL) == -1) {

      ALOGE("sigprocmask(SIG_SETMASK, { SIGCHLD }) failed: %s", strerror(errno));

      RuntimeAbort(env, __LINE__, "Call to sigprocmask(SIG_UNBLOCK, { SIGCHLD }) failed.");

    }



    // Keep capabilities across UID change, unless we're staying root.

    if (uid != 0) {

      EnableKeepCapabilities(env);
@@ -609,6 +628,12 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra 
    }

  } else if (pid > 0) {

    // the parent process



    // We blocked SIGCHLD prior to a fork, we unblock it here.

    if (sigprocmask(SIG_UNBLOCK, &sigchld, NULL) == -1) {

      ALOGE("sigprocmask(SIG_SETMASK, { SIGCHLD }) failed: %s", strerror(errno));

      RuntimeAbort(env, __LINE__, "Call to sigprocmask(SIG_UNBLOCK, { SIGCHLD }) failed.");

    }

  }

  return pid;

}