Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1e45cd0 authored by Gustav Sennton's avatar Gustav Sennton
Browse files

Fetch WebView package even if it is uninstalled for the current user. 

Since the WebView loading mechanism is global - it doesn't differ
between different users, a user for which the current WebView provider
is uninstalled won't be able to fetch any information about the current
provider without passing a certain flag (MATCH_UNINSTALLED_PACKAGES) to
the package manager.

Bug: 26677081
Change-Id: Id1b86164bb22fc7285d292da1b1115fb25e4d226
parent 4370fba5

core/java/android/webkit/WebViewFactory.java

+16 −4
Original line number Diff line number Diff line
@@ -295,15 +295,27 @@ public final class WebViewFactory { 


            Application initialApplication = AppGlobals.getInitialApplication();

            Context webViewContext = null;

            Trace.traceBegin(Trace.TRACE_TAG_WEBVIEW, "initialApplication.createPackageContext()");

            Trace.traceBegin(Trace.TRACE_TAG_WEBVIEW, "PackageManager.getApplicationInfo()");

            try {

                // Construct a package context to load the Java code into the current app.

                // This is done as early as possible since by constructing a package context we

                // register the WebView package as a dependency for the current application so that

                // when the WebView package is updated this application will be killed.

                webViewContext = initialApplication.createPackageContext(

                        sPackageInfo.packageName,

                ApplicationInfo applicationInfo =

                    initialApplication.getPackageManager().getApplicationInfo(

                        sPackageInfo.packageName, PackageManager.GET_SHARED_LIBRARY_FILES

                        | PackageManager.MATCH_DEBUG_TRIAGED_MISSING

                        // make sure that we fetch the current provider even if its not installed

                        // for the current user

                        | PackageManager.MATCH_UNINSTALLED_PACKAGES);

                Trace.traceBegin(Trace.TRACE_TAG_WEBVIEW,

                        "initialApplication.createApplicationContext");

                try {

                    webViewContext = initialApplication.createApplicationContext(applicationInfo,

                            Context.CONTEXT_INCLUDE_CODE | Context.CONTEXT_IGNORE_SECURITY);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_WEBVIEW);

                }

            } catch (PackageManager.NameNotFoundException e) {

                throw new MissingWebViewPackageException(e);

            } finally {