Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b166f6f1 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Only do the ble scan if association isNotifyOnDeviceNearby" into tm-dev am: 6ad21dae

parents 3b94e8fc 6ad21dae
Loading
Loading
Loading
Loading
+3 −0
Original line number Original line Diff line number Diff line
@@ -671,6 +671,9 @@ public class CompanionDeviceManagerService extends SystemService {
            association = AssociationInfo.builder(association)
            association = AssociationInfo.builder(association)
                    .setNotifyOnDeviceNearby(active)
                    .setNotifyOnDeviceNearby(active)
                    .build();
                    .build();
            // Do not need to call {@link BleCompanionDeviceScanner#restartScan()} since it will
            // trigger {@link BleCompanionDeviceScanner#restartScan(int, AssociationInfo)} when
            // an application sets/unsets the mNotifyOnDeviceNearby flag.
            mAssociationStore.updateAssociation(association);
            mAssociationStore.updateAssociation(association);


            // TODO(b/218615198): correctly handle the case when the device is currently present.
            // TODO(b/218615198): correctly handle the case when the device is currently present.
+2 −0
Original line number Original line Diff line number Diff line
@@ -194,6 +194,8 @@ class BleCompanionDeviceScanner implements AssociationStore.OnChangeListener {
        // Collect MAC addresses from all associations.
        // Collect MAC addresses from all associations.
        final Set<String> macAddresses = new HashSet<>();
        final Set<String> macAddresses = new HashSet<>();
        for (AssociationInfo association : mAssociationStore.getAssociations()) {
        for (AssociationInfo association : mAssociationStore.getAssociations()) {
            if (!association.isNotifyOnDeviceNearby()) continue;

            // Beware that BT stack does not consider low-case MAC addresses valid, while
            // Beware that BT stack does not consider low-case MAC addresses valid, while
            // MacAddress.toString() return a low-case String.
            // MacAddress.toString() return a low-case String.
            final String macAddress = association.getDeviceMacAddressAsString();
            final String macAddress = association.getDeviceMacAddressAsString();