Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0df70b6 authored by Nathan Harold's avatar Nathan Harold Committed by android-build-merger
Browse files

Merge "Disable the AppOp Restriction for IpSec Tunnels" into stage-aosp-master

am: bda7c960

Change-Id: I98f2a964b3035daf93b54dc2b72561b16d2ded92
parents 94976cab bda7c960
Loading
Loading
Loading
Loading
+15 −11
Original line number Diff line number Diff line
@@ -1481,10 +1481,13 @@ public class IpSecService extends IIpSecService.Stub {
        }
    }

    private static final String TUNNEL_OP = "STOPSHIP"; // = AppOpsManager.OP_MANAGE_IPSEC_TUNNELS;

    private void enforceTunnelPermissions(String callingPackage) {
        checkNotNull(callingPackage, "Null calling package cannot create IpSec tunnels");
        if (false) { // STOPSHIP if this line is present
            switch (getAppOpsManager().noteOp(
                    AppOpsManager.OP_MANAGE_IPSEC_TUNNELS,
                        TUNNEL_OP,
                        Binder.getCallingUid(), callingPackage)) {
                case AppOpsManager.MODE_DEFAULT:
                    mContext.enforceCallingOrSelfPermission(
@@ -1496,6 +1499,7 @@ public class IpSecService extends IIpSecService.Stub {
                    throw new SecurityException("Request to ignore AppOps for non-legacy API");
            }
        }
    }

    private void createOrUpdateTransform(
            IpSecConfig c, int resourceId, SpiRecord spiRecord, EncapSocketRecord socketRecord)
+2 −0
Original line number Diff line number Diff line
@@ -50,6 +50,7 @@ import java.util.Arrays;
import java.util.Collection;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@@ -592,6 +593,7 @@ public class IpSecServiceParameterizedTest {
        }
    }

    @Ignore
    @Test
    public void testAddTunnelFailsForBadPackageName() throws Exception {
        try {