Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afc3a227 authored by mattgilbride's avatar mattgilbride Committed by Matt Gilbride
Browse files

Create AndroidGlobalLintChecker 

This change creates a separate lint jar "AndroidGlobalLintChecker".  This set of custom checks that is intended to be global.  These checks should run across the entire tree, not just the framework.

- separate lint checking code broadly into "common", "framework", and
  "global"
- publish AndroidGlobalLintChecker into the android distribution for
  consumption by prebuilts/cmdline-tools

Bug: 236558918
Test: AndroidGlobalLintCheckerTest
Change-Id: Ib1606a7bc8adfab2f13974e7366288a4e44bbfa2
parent b769860c

tools/lint/common/Android.bp

0 → 100644
+29 −0
Original line number Diff line number Diff line 
// Copyright (C) 2022 The Android Open Source Project

//

// Licensed under the Apache License, Version 2.0 (the "License");

// you may not use this file except in compliance with the License.

// You may obtain a copy of the License at

//

//      http://www.apache.org/licenses/LICENSE-2.0

//

// Unless required by applicable law or agreed to in writing, software

// distributed under the License is distributed on an "AS IS" BASIS,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

// See the License for the specific language governing permissions and

// limitations under the License.



package {

    // See: http://go/android-license-faq

    // A large-scale-change added 'default_applicable_licenses' to import

    // all of the 'license_kinds' from "frameworks_base_license"

    // to get the below license kinds:

    //   SPDX-license-identifier-Apache-2.0

    default_applicable_licenses: ["frameworks_base_license"],

}



java_library_host {

    name: "AndroidCommonLint",

    srcs: ["src/main/java/**/*.kt"],

    libs: ["lint_api"],

    kotlincflags: ["-Xjvm-default=all"],

}

tools/lint/common/src/main/java/com/google/android/lint/PermissionMethodUtils.kt

0 → 100644
+36 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2022 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.google.android.lint



import com.android.tools.lint.detector.api.getUMethod

import org.jetbrains.uast.UCallExpression

import org.jetbrains.uast.UMethod

import org.jetbrains.uast.UParameter



fun isPermissionMethodCall(callExpression: UCallExpression): Boolean {

    val method = callExpression.resolve()?.getUMethod() ?: return false

    return hasPermissionMethodAnnotation(method)

}



fun hasPermissionMethodAnnotation(method: UMethod): Boolean = method.annotations

        .any {

            it.hasQualifiedName(ANNOTATION_PERMISSION_METHOD)

        }



fun hasPermissionNameAnnotation(parameter: UParameter) = parameter.annotations.any {

    it.hasQualifiedName(ANNOTATION_PERMISSION_NAME)

}

tools/lint/fix/Android.bp

0 → 100644
+28 −0
Original line number Diff line number Diff line 
// Copyright (C) 2022 The Android Open Source Project

//

// Licensed under the Apache License, Version 2.0 (the "License");

// you may not use this file except in compliance with the License.

// You may obtain a copy of the License at

//

//      http://www.apache.org/licenses/LICENSE-2.0

//

// Unless required by applicable law or agreed to in writing, software

// distributed under the License is distributed on an "AS IS" BASIS,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

// See the License for the specific language governing permissions and

// limitations under the License.



package {

    // See: http://go/android-license-faq

    // A large-scale-change added 'default_applicable_licenses' to import

    // all of the 'license_kinds' from "frameworks_base_license"

    // to get the below license kinds:

    //   SPDX-license-identifier-Apache-2.0

    default_applicable_licenses: ["frameworks_base_license"],

}



python_binary_host {

    name: "lint_fix",

    main: "lint_fix.py",

    srcs: ["lint_fix.py"],

}