Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afbd0aa9 authored by riddle_hsu's avatar riddle_hsu Committed by Steve Kondik
Browse files

[ActivityManager] Prevent coredump file may not complete for testing. 

Sympton:
During testing, skip kill native crash process manually because it will continue to die by default.

Root Cause:
Large process may take some time to do coredump.In auto test, crash process will be killed immediately that results incomplete coredump file.

Solution:
If the tester (IActivityController) will handle app crash event,
Do not kill native crashed process if the rom is debuggable.

Change-Id: Ia360af147d694125d440e5ba2f958c4759a50494
parent 13e22d76

services/java/com/android/server/am/ActivityManagerService.java

100755 → 100644
+9 −3
Original line number Original line Diff line number Diff line
@@ -10205,9 +10205,15 @@ public final class ActivityManagerService extends ActivityManagerNative 
                    int pid = r != null ? r.pid : Binder.getCallingPid();

                    int pid = r != null ? r.pid : Binder.getCallingPid();

                    if (!mController.appCrashed(name, pid,

                    if (!mController.appCrashed(name, pid,

                            shortMsg, longMsg, timeMillis, crashInfo.stackTrace)) {

                            shortMsg, longMsg, timeMillis, crashInfo.stackTrace)) {

                        if ("1".equals(SystemProperties.get(SYSTEM_DEBUGGABLE, "0"))

                                && "Native crash".equals(crashInfo.exceptionClassName)) {

                            Slog.w(TAG, "Skip killing native crashed app " + name

                                    + "(" + pid + ") during testing");

                        } else {

                            Slog.w(TAG, "Force-killing crashed app " + name

                            Slog.w(TAG, "Force-killing crashed app " + name

                                    + " at watcher's request");

                                    + " at watcher's request");

                            Process.killProcess(pid);

                            Process.killProcess(pid);

                        }

                        return;

                        return;

                    }

                    }

                } catch (RemoteException e) {

                } catch (RemoteException e) {