Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af809557 authored by Pinyao Ting's avatar Pinyao Ting Committed by Automerger Merge Worker
Browse files

Merge "Fix a security issue in app widget service." into qt-dev am: 5a292b8b am: f90c7700 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/20026360



Change-Id: I170c5947cf1aedce8dfd11a99132bcbb1a760b4d
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents bdb417dc f90c7700

core/java/android/appwidget/AppWidgetManager.java

+3 −1
Original line number Diff line number Diff line
@@ -1109,7 +1109,9 @@ public class AppWidgetManager { 
     * @param intent        The intent of the service which will be providing the data to the

     *                      RemoteViewsAdapter.

     * @param connection    The callback interface to be notified when a connection is made or lost.

     * @param flags         Flags used for binding to the service

     * @param flags         Flags used for binding to the service. Currently only

     *                     {@link Context#BIND_AUTO_CREATE} and

     *                     {@link Context#BIND_FOREGROUND_SERVICE_WHILE_AWAKE} are supported.

     *

     * @see Context#getServiceDispatcher(ServiceConnection, Handler, int)

     * @hide

services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java

+4 −3
Original line number Diff line number Diff line
@@ -1318,8 +1318,9 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku 
                if (ActivityManager.getService().bindService(

                        caller, activtiyToken, intent,

                        intent.resolveTypeIfNeeded(mContext.getContentResolver()),

                        connection, flags, mContext.getOpPackageName(),

                        widget.provider.getUserId()) != 0) {

                        connection, flags & (Context.BIND_AUTO_CREATE

                                | Context.BIND_FOREGROUND_SERVICE_WHILE_AWAKE),

                        mContext.getOpPackageName(), widget.provider.getUserId()) != 0) {



                    // Add it to the mapping of RemoteViewsService to appWidgetIds so that we

                    // can determine when we can call back to the RemoteViewsService later to