Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af53308a authored by Dmitri Plotnikov's avatar Dmitri Plotnikov
Browse files

Revert^2 "Reduce battery level reporting delay in battery history" 

This reverts commit 3f03d2ab.

Reason for revert: Rolling forward after fixing the b/408215413 regression

Change-Id: I69fdb98ec25d4d8f7a0390da4262725e0b697c2a
parent 3f03d2ab

services/core/java/com/android/server/am/BatteryStatsService.java

+14 −30
Original line number Diff line number Diff line
@@ -2908,37 +2908,21 @@ public final class BatteryStatsService extends IBatteryStats.Stub 
            final long elapsedRealtime = SystemClock.elapsedRealtime();

            final long uptime = SystemClock.uptimeMillis();

            final long currentTime = System.currentTimeMillis();

            // We still schedule this task over the handler thread to make sure we've had

            // all existing pending work handled before setting the battery state

            mHandler.post(() -> {

                // BatteryService calls us here and we may update external state. It would be wrong

                // to block such a low level service like BatteryService on external stats like WiFi

                mWorker.scheduleRunnable(() -> {

                    synchronized (mStats) {

            final boolean onBattery = BatteryStatsImpl.isOnBattery(plugType, status);

                        if (mStats.isOnBattery() == onBattery) {

                            // The battery state has not changed, so we don't need to sync external

                            // stats immediately.

                            mStats.setBatteryStateLocked(status, health, plugType, level, temp,

                                    volt, chargeUAh, chargeFullUAh, chargeTimeToFullSeconds,

                                    elapsedRealtime, uptime, currentTime);

                            return;

                        }

            final boolean batteryStateChanged;

            synchronized (mStats) {

                batteryStateChanged = mStats.isOnBattery() != onBattery;

            }



                    // Sync external stats first as the battery has changed states. If we don't sync

                    // before changing the state, we may not collect the relevant data later.

                    // Order here is guaranteed since we're scheduling from the same thread and we

                    // are using a single threaded executor.

                    mWorker.scheduleSync("battery-state", BatteryExternalStatsWorker.UPDATE_ALL);

                    mWorker.scheduleRunnable(() -> {

            mHandler.post(() -> {

                synchronized (mStats) {

                            mStats.setBatteryStateLocked(status, health, plugType, level, temp,

                                    volt, chargeUAh, chargeFullUAh, chargeTimeToFullSeconds,

                    mStats.setBatteryStateLocked(status, health, plugType, level, temp, volt,

                            chargeUAh, chargeFullUAh, chargeTimeToFullSeconds,

                            elapsedRealtime, uptime,currentTime);

                }

                    });

                });

                if (batteryStateChanged) {

                    mWorker.scheduleSync("battery-state",

                            BatteryExternalStatsWorker.UPDATE_ALL);

                }

            });

        }

    }