Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae8d7cff authored by Caitlin Cassidy's avatar Caitlin Cassidy Committed by Android (Google) Code Review
Browse files

Merge "[Status Bar] Fix NPE in #dumpBarTransitions." into sc-dev

parents 100b0929 2f583ee7

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBar.java

+7 −2
Original line number Diff line number Diff line
@@ -2778,9 +2778,14 @@ public class StatusBar extends SystemUI implements DemoMode, 
                + String.valueOf(CameraIntents.getOverrideCameraPackage(mContext)));

    }



    public static void dumpBarTransitions(PrintWriter pw, String var, BarTransitions transitions) {

    public static void dumpBarTransitions(

            PrintWriter pw, String var, @Nullable BarTransitions transitions) {

        pw.print("  "); pw.print(var); pw.print(".BarTransitions.mMode=");

        if (transitions != null) {

            pw.println(BarTransitions.modeToString(transitions.getMode()));

        } else {

            pw.println("Unknown");

        }

    }



    public void createAndAddWindows(@Nullable RegisterStatusBarResult result) {

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarTest.java

+6 −0
Original line number Diff line number Diff line
@@ -776,6 +776,12 @@ public class StatusBarTest extends SysuiTestCase { 
        mStatusBar.dump(null, new PrintWriter(new ByteArrayOutputStream()), null);

    }



    @Test

    public void testDumpBarTransitions_DoesNotCrash() {

        StatusBar.dumpBarTransitions(

                new PrintWriter(new ByteArrayOutputStream()), "var", /* transitions= */ null);

    }



    @Test

    @RunWithLooper(setAsMainLooper = true)

    public void testUpdateKeyguardState_DoesNotCrash() {