Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae749fb5 authored by Lyn Han's avatar Lyn Han
Browse files

Increase pointer size, move closer to bubble 

Make selection easier to see

Bug: 158482996
Test: manual
Change-Id: I34f80d26bc30f9b46edcfad11ac655c895a58784
parent 296855fe

packages/SystemUI/res/values/dimens.xml

+2 −2
Original line number Diff line number Diff line
@@ -1220,9 +1220,9 @@ 
    <!-- Padding of bubble overflow empty state subtitle -->

    <dimen name="bubble_empty_overflow_subtitle_padding">50dp</dimen>

    <!-- Height of the triangle that points to the expanded bubble -->

    <dimen name="bubble_pointer_height">4dp</dimen>

    <dimen name="bubble_pointer_height">8dp</dimen>

    <!-- Width of the triangle that points to the expanded bubble -->

    <dimen name="bubble_pointer_width">6dp</dimen>

    <dimen name="bubble_pointer_width">12dp</dimen>

    <!-- Extra padding around the dismiss target for bubbles -->

    <dimen name="bubble_dismiss_slop">16dp</dimen>

    <!-- Height of button allowing users to adjust settings for bubbles. -->

packages/SystemUI/src/com/android/systemui/bubbles/BubbleStackView.java

+1 −3
Original line number Diff line number Diff line
@@ -272,7 +272,6 @@ public class BubbleStackView extends FrameLayout 
    private int mBubbleTouchPadding;

    private int mExpandedViewPadding;

    private int mCornerRadius;

    private int mPointerHeight;

    private int mStatusBarHeight;

    private int mImeOffset;

    @Nullable private BubbleViewProvider mExpandedBubble;
@@ -746,7 +745,6 @@ public class BubbleStackView extends FrameLayout 
        mBubbleElevation = res.getDimensionPixelSize(R.dimen.bubble_elevation);

        mBubblePaddingTop = res.getDimensionPixelSize(R.dimen.bubble_padding_top);

        mBubbleTouchPadding = res.getDimensionPixelSize(R.dimen.bubble_touch_padding);

        mPointerHeight = res.getDimensionPixelSize(R.dimen.bubble_pointer_height);



        mStatusBarHeight =

                res.getDimensionPixelSize(com.android.internal.R.dimen.status_bar_height);
@@ -2339,7 +2337,7 @@ public class BubbleStackView extends FrameLayout 
     * Calculates the y position of the expanded view when it is expanded.

     */

    float getExpandedViewY() {

        return getStatusBarHeight() + mBubbleSize + mBubblePaddingTop + mPointerHeight;

        return getStatusBarHeight() + mBubbleSize + mBubblePaddingTop;

    }



    /**