Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adfb0d0c authored by Robert Greenwalt's avatar Robert Greenwalt
Browse files

Make tethering ignore bad inputs 

Tethering was re-evaluating everything on any connectivity change.
This was causing problems when mobile data was not available as each
re-eval was again requesting a connection which would fail and loop.
Ignore FAILED states to break this cycle in a minimal change.

bug:6668233
Change-Id: Ia1dfc6abff1fe464e9501b50185cdb8d0fbb7ff6
parent e446e6c9

services/java/com/android/server/connectivity/Tethering.java

+7 −2
Original line number Diff line number Diff line
@@ -500,11 +500,16 @@ public class Tethering extends INetworkManagementEventObserver.Stub { 
                    mUsbTetherRequested = false;

                }

            } else if (action.equals(ConnectivityManager.CONNECTIVITY_ACTION)) {

                NetworkInfo networkInfo = (NetworkInfo)intent.getParcelableExtra(

                        ConnectivityManager.EXTRA_NETWORK_INFO);

                if (networkInfo != null &&

                        networkInfo.getDetailedState() != NetworkInfo.DetailedState.FAILED) {

                    if (VDBG) Log.d(TAG, "Tethering got CONNECTIVITY_ACTION");

                    mTetherMasterSM.sendMessage(TetherMasterSM.CMD_UPSTREAM_CHANGED);

                }

            }

        }

    }



    private void tetherUsb(boolean enable) {

        if (VDBG) Log.d(TAG, "tetherUsb " + enable);