Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit addc2700 authored by chen xu's avatar chen xu
Browse files

listen to correct intent extra for defaultSubIdChange 

TelephonyRegistry listen for the wrong intent extra PhoneConstants.SLOT
which has been removed recently. Thus when receive default subscription
id changed event, we mistenkenly thought phone ID is invalid,
thus we never update mDefaultPhoneId and mDefaultSubId and fails to
notify listeners on default subscription

Bug: 131915645
Test: Manual
Change-Id: Ibb79e55c0756b30669cbd5c69c181f9f9c4d186b
parent a9ac86f6

services/core/java/com/android/server/TelephonyRegistry.java

+3 −3
Original line number Diff line number Diff line
@@ -342,7 +342,7 @@ public class TelephonyRegistry extends ITelephonyRegistry.Stub { 
                Integer newDefaultSubIdObj = new Integer(intent.getIntExtra(

                        PhoneConstants.SUBSCRIPTION_KEY,

                        SubscriptionManager.getDefaultSubscriptionId()));

                int newDefaultPhoneId = intent.getIntExtra(PhoneConstants.SLOT_KEY,

                int newDefaultPhoneId = intent.getIntExtra(PhoneConstants.PHONE_KEY,

                    SubscriptionManager.getPhoneId(mDefaultSubId));

                if (DBG) {

                    log("onReceive:current mDefaultSubId=" + mDefaultSubId
@@ -1935,8 +1935,8 @@ public class TelephonyRegistry extends ITelephonyRegistry.Stub { 
            pw.println("mEmergencyNumberList=" + mEmergencyNumberList);

            pw.println("mCallQuality=" + mCallQuality);

            pw.println("mCallAttributes=" + mCallAttributes);

            pw.println("mDefaultPhoneId" + mDefaultPhoneId);

            pw.println("mDefaultSubId" + mDefaultSubId);

            pw.println("mDefaultPhoneId=" + mDefaultPhoneId);

            pw.println("mDefaultSubId=" + mDefaultSubId);



            pw.decreaseIndent();