Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad6fbf6b authored by Riddle Hsu's avatar Riddle Hsu
Browse files

Pause transient launch after switching to a translucent task 

The activity lifecycle change of transient launch is usually deferred
until the transition is finished to reduce switch latency. It is fine
if transient launch will be invisible because ensureActivitiesVisible
will schedule to stop the activity. But if not, such as moving a
translucent task to top, then the non-top visible home will stay at
resumed state unexpectedly.

Bug: 419630442
Flag: EXEMPT bugfix
Test: atest TransitionTests#testTransientLaunchWithTranslucentTask
Test: While home is recents. Launch an opaque app.
      Enter recents. Switch to a translucent app.
      Home should be paused.

Change-Id: I0e964088b08f0351cdda354717f78c717cdfe81b
parent c009172c

services/core/java/com/android/server/wm/Transition.java

+4 −0
Original line number Original line Diff line number Diff line
@@ -1285,6 +1285,10 @@ class Transition implements BLASTSyncEngine.TransactionReadyListener { 
            // Prevent spurious background app switches.

            // Prevent spurious background app switches.

            if (ar.mDisplayContent.mFocusedApp == ar) {

            if (ar.mDisplayContent.mFocusedApp == ar) {

                mController.mAtm.stopAppSwitches();

                mController.mAtm.stopAppSwitches();

            } else if (ar.isState(RESUMED) && task.getVisibility(null /* starting */)

                    == TaskFragment.TASK_FRAGMENT_VISIBILITY_VISIBLE_BEHIND_TRANSLUCENT) {

                ar.getTaskFragment().startPausing(false /* uiSleeping */, null /* resuming */,

                        "finishTransition-behind-translucent");

            }

            }

            found = true;

            found = true;

        }

        }

services/tests/wmtests/src/com/android/server/wm/TransitionTests.java

+14 −0
Original line number Original line Diff line number Diff line
@@ -1651,6 +1651,20 @@ public class TransitionTests extends WindowTestsBase { 
        // Transition#finishTransition -> updateImeForVisibleTransientLaunch.

        // Transition#finishTransition -> updateImeForVisibleTransientLaunch.

        verify(mDisplayContent).computeImeLayeringTarget(true /* update */);

        verify(mDisplayContent).computeImeLayeringTarget(true /* update */);

        assertFalse(translucentApp.isVisible());

        assertFalse(translucentApp.isVisible());



        // Simulate switching/returning to the translucent activity while the recent is running.

        recent.setState(ActivityRecord.State.RESUMED, "test");

        final Transition transition2 = createTestTransition(TRANSIT_OPEN, player.mController);

        player.mController.moveToCollecting(transition2);

        player.mController.requestStartTransition(transition2, taskRecent,

                null /* remoteTransition */, null /* displayChange */);

        transition2.setTransientLaunch(recent, taskRecent);

        translucentApp.getTask().moveToFront("move-translucent-to-front");

        mDisplayContent.setFocusedApp(translucentApp);

        player.start();

        player.finish();

        // The translucent activity is moved to top, so the recent should be scheduled to pause.

        assertEquals(recent.getState(), ActivityRecord.State.PAUSING);

    }

    }





    @Test

    @Test