Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad46ae1b authored by Shuo Qian's avatar Shuo Qian
Browse files

API Review Feedbacks 

1) Rethrow the remoteException instead of returning empty string
 for CarrierConfigManager#getDefaultCarrierServicePackageName()

2) Flip documentation to use “valid” instead of “invalid” for
 ModemActivityInfo.isValid()

Bug: 147804136
Test: Treehugger; Cts
Change-Id: I595837dfb24a09c68e33a732aa24b5b25ff28ac0
parent a3243e8e

telephony/java/android/telephony/CarrierConfigManager.java

+1 −0
Original line number Diff line number Diff line
@@ -4110,6 +4110,7 @@ public class CarrierConfigManager { 
        } catch (RemoteException ex) {

            Rlog.e(TAG, "getDefaultCarrierServicePackageName ICarrierConfigLoader is null"

                    + ex.toString());

            ex.rethrowAsRuntimeException();

        }

        return "";

    }

telephony/java/android/telephony/ModemActivityInfo.java

+1 −1
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ public final class ModemActivityInfo implements Parcelable { 
    }



    /**

     * Indicate if the ModemActivityInfo is invalid due to modem's invalid reporting.

     * Indicates if the modem has reported valid {@link ModemActivityInfo}.

     *

     * @return {@code true} if this {@link ModemActivityInfo} record is valid,

     * {@code false} otherwise.