Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad28b528 authored by Mill Chen's avatar Mill Chen
Browse files

Remove click action from AccessibilityNodeInfo 

Due to the requirement that the SliderPreference be selectable for
keyboard navigation and to display a dialog when restricted, it must be
set as selectable. However, this causes accessibility services to
announce an irrelevant description when the slider preference is
focused. Removing click action from AccessibilityNodeInfo to fix it.

Bug: 431890794
Test: Manual test with Talkback and test with CtsVerifier
Flag: EXEMPT only changing accessibility node info
Change-Id: Id14fb4849045c87d1130c789962c921640984304
parent d62e8794

packages/SettingsLib/SliderPreference/src/com/android/settingslib/widget/SliderPreference.java

+11 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ import android.util.Log; 
import android.view.KeyEvent;

import android.view.View;

import android.view.ViewGroup;

import android.view.accessibility.AccessibilityNodeInfo;

import android.widget.ImageView;

import android.widget.TextView;
@@ -409,6 +410,16 @@ public class SliderPreference extends Preference { 


        ImageView iconEndView = (ImageView) holder.findViewById(R.id.icon_end);

        updateIconEndIfNeeded(iconEndView);



        // Remove the accessibility label of click action

        holder.itemView.getRootView().setAccessibilityDelegate(new View.AccessibilityDelegate() {

            @Override

            public void onInitializeAccessibilityNodeInfo(View host, AccessibilityNodeInfo info) {

                super.onInitializeAccessibilityNodeInfo(host, info);

                info.removeAction(AccessibilityNodeInfo.ACTION_CLICK);

                info.setClickable(false);

            }

        });

    }



    /**