Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ace92b87 authored by Iain Merrick's avatar Iain Merrick
Browse files

Include .php tests in DumpRenderTree2. 

I've manually checked the existing LayoutTests for false positives.
There are non-test .php files, but they're all in "resources"
subdirectories, so they should be caught by isTestDir(). Added an
extra @warning to isTestFile() just in case.

Bug: 3164771
Change-Id: Ib282acf46f6e839439ce521c4b2cb5820fcd263c
parent 494081aa

tests/DumpRenderTree2/src/com/android/dumprendertree2/FileFilter.java

+7 −2
Original line number Diff line number Diff line
@@ -240,13 +240,18 @@ public class FileFilter { 


    /**

     * Checks if the file is a test.

     * Currently we run .html and .xhtml tests.

     * Currently we run .html, .xhtml and .php tests.

     *

     * @warning You MUST also call isTestDir() on the parent directory before

     * assuming that a file is a test.

     *

     * @param testName

     * @return if the file is a test

     */

    public static boolean isTestFile(String testName) {

        return testName.endsWith(".html") || testName.endsWith(".xhtml");

        return testName.endsWith(".html")

            || testName.endsWith(".xhtml")

            || testName.endsWith(".php");

    }



    /**