Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acdacbfe authored by Chalard Jean's avatar Chalard Jean Committed by Android (Google) Code Review
Browse files

Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev

parents b74db233 fe5e23f8
Loading
Loading
Loading
Loading
+8 −0
Original line number Diff line number Diff line
@@ -7134,6 +7134,14 @@ public class ConnectivityService extends IConnectivityManager.Stub
            networkAgent.networkCapabilities.addCapability(NET_CAPABILITY_FOREGROUND);

            if (!createNativeNetwork(networkAgent)) return;
            if (networkAgent.isVPN()) {
                // Initialize the VPN capabilities to their starting values according to the
                // underlying networks. This will avoid a spurious callback to
                // onCapabilitiesUpdated being sent in updateAllVpnCapabilities below as
                // the VPN would switch from its default, blank capabilities to those
                // that reflect the capabilities of its underlying networks.
                updateAllVpnsCapabilities();
            }
            networkAgent.created = true;
        }

+0 −2
Original line number Diff line number Diff line
@@ -5387,8 +5387,6 @@ public class ConnectivityServiceTest {

        // Even though the VPN is unvalidated, it becomes the default network for our app.
        callback.expectAvailableCallbacksUnvalidated(vpnNetworkAgent);
        // TODO: this looks like a spurious callback.
        callback.expectCallback(CallbackEntry.NETWORK_CAPS_UPDATED, vpnNetworkAgent);
        callback.assertNoCallback();

        assertTrue(vpnNetworkAgent.getScore() > mEthernetNetworkAgent.getScore());