Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acd021ee authored by Amin Shaikh's avatar Amin Shaikh
Browse files

Remove QSPanel bounds after expansion animation. 

QSPanel#setClipBounds is called during the expansion animation of QS,
but were not cleared after full expansion. Tiles added in the
customization flow properly expanded the QSPanel's size, but were not
drawn to the screen due to the stale view bounds. Clearing these bounds
also ensures that screen orientation changes properly redistribute the
tiles (e.g. 3x4 -> 3x4).

Bug: 70799330
Test: visual; adding tiles and rotating expanded QS
Change-Id: Ibab7d1ce7657d76cccf3957fd3dc1c8c2772f16f
parent 4b66fc6b

packages/SystemUI/src/com/android/systemui/qs/QSFragment.java

+12 −7
Original line number Diff line number Diff line
@@ -285,19 +285,24 @@ public class QSFragment extends Fragment implements QS { 
        int heightDiff = mQSPanel.getBottom() - mHeader.getBottom() + mHeader.getPaddingBottom()

                + mFooter.getHeight();

        mQSPanel.setTranslationY(translationScaleY * heightDiff);

        mQSDetail.setFullyExpanded(expansion == 1);



        if (mQSAnimator != null) {

            mQSAnimator.setPosition(expansion);

        }



        // Set bounds on the QS panel so it doesn't run over the header.

        boolean fullyExpanded = expansion == 1;

        mQSDetail.setFullyExpanded(fullyExpanded);

        if (fullyExpanded) {

            // Always draw within the bounds of the view when fully expanded.

            mQSPanel.setClipBounds(null);

        } else {

            // Set bounds on the QS panel so it doesn't run over the header when animating.

            mQsBounds.top = (int) -mQSPanel.getTranslationY();

            mQsBounds.right = mQSPanel.getWidth();

            mQsBounds.bottom = mQSPanel.getHeight();

            mQSPanel.setClipBounds(mQsBounds);

        }



        if (mQSAnimator != null) {

            mQSAnimator.setPosition(expansion);

        }

    }



    @Override

    public void animateHeaderSlidingIn(long delay) {

        if (DEBUG) Log.d(TAG, "animateHeaderSlidingIn");