Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aca3912b authored by Daniel Norman's avatar Daniel Norman
Browse files

Delete unused param in MagModeSwitch#getIconResId 

Fix: 242233514
Test: presubmit
Flag: EXEMPT mechanical refactor
Change-Id: I6d22815cee05977ef1c261e4d9b67111d275d62d
parent e0519f2f

packages/SystemUI/src/com/android/systemui/accessibility/MagnificationModeSwitch.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -305,7 +305,7 @@ class MagnificationModeSwitch implements MagnificationGestureDetector.OnGestureL 
        }

        }

        if (mMagnificationMode != mode) {

        if (mMagnificationMode != mode) {

            mMagnificationMode = mode;

            mMagnificationMode = mode;

            mImageView.setImageResource(getIconResId(mMagnificationMode));

            mImageView.setImageResource(getIconResId());

        }

        }

        if (!mIsVisible) {

        if (!mIsVisible) {

            onConfigurationChanged(mContext.getResources().getConfiguration());

            onConfigurationChanged(mContext.getResources().getConfiguration());
@@ -455,7 +455,7 @@ class MagnificationModeSwitch implements MagnificationGestureDetector.OnGestureL 
    }

    }





    @VisibleForTesting

    @VisibleForTesting

    static int getIconResId(int mode) { // TODO(b/242233514): delete non used param

    static int getIconResId() {

        return R.drawable.ic_open_in_new_window;

        return R.drawable.ic_open_in_new_window;

    }

    }

packages/SystemUI/tests/src/com/android/systemui/accessibility/MagnificationModeSwitchTest.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -168,8 +168,7 @@ public class MagnificationModeSwitchTest extends SysuiTestCase { 
    public void showFullscreenModeButton_addViewAndSetImageResource() {

    public void showFullscreenModeButton_addViewAndSetImageResource() {

        mMagnificationModeSwitch.showButton(ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);

        mMagnificationModeSwitch.showButton(ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);





        verify(mSpyImageView).setImageResource(

        verify(mSpyImageView).setImageResource(getIconResId());

                getIconResId(ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN));

        assertEquals(mSpyImageView, mWindowManager.getAttachedView());

        assertEquals(mSpyImageView, mWindowManager.getAttachedView());

        assertShowFadingAnimation(FADE_IN_ALPHA);

        assertShowFadingAnimation(FADE_IN_ALPHA);

        assertShowFadingAnimation(FADE_OUT_ALPHA);

        assertShowFadingAnimation(FADE_OUT_ALPHA);