Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac9577f9 authored by Diya Bera's avatar Diya Bera
Browse files

SysUI filters fingerprint errors from keyguard 

"Power pressed" and "Verification ended" strings are suppressed in keyguard.

Test: atest KeyguardIndicationControllerTest

Fixes: 246619759
Fixes: 247900107
Change-Id: I8277ea87f0ca6c5293767bb4f598989fa2a0f1c0
parent ce1e8cee

packages/SystemUI/src/com/android/systemui/statusbar/KeyguardIndicationController.java

+2 −1
Original line number Diff line number Diff line
@@ -1183,7 +1183,8 @@ public class KeyguardIndicationController { 
            return ((!updateMonitor.isUnlockingWithBiometricAllowed(true /* isStrongBiometric */)

                    && msgId != FingerprintManager.FINGERPRINT_ERROR_LOCKOUT_PERMANENT)

                    || msgId == FingerprintManager.FINGERPRINT_ERROR_CANCELED

                    || msgId == FingerprintManager.FINGERPRINT_ERROR_USER_CANCELED);

                    || msgId == FingerprintManager.FINGERPRINT_ERROR_USER_CANCELED

                    || msgId == FingerprintManager.BIOMETRIC_ERROR_POWER_PRESSED);

        }



        private boolean shouldSuppressFaceError(int msgId, KeyguardUpdateMonitor updateMonitor) {

packages/SystemUI/tests/src/com/android/systemui/statusbar/KeyguardIndicationControllerTest.java

+13 −0
Original line number Diff line number Diff line
@@ -628,6 +628,19 @@ public class KeyguardIndicationControllerTest extends SysuiTestCase { 
        verifyNoMessage(INDICATION_TYPE_TRANSIENT);

    }



    @Test

    public void transientIndication_visibleWhenDozing_ignoresPowerPressed() {

        createController();



        mController.setVisible(true);

        reset(mRotateTextViewController);

        mController.getKeyguardCallback().onBiometricError(

                FingerprintManager.BIOMETRIC_ERROR_POWER_PRESSED, "foo",

                BiometricSourceType.FINGERPRINT);



        verifyNoMessage(INDICATION_TYPE_BIOMETRIC_MESSAGE);

    }



    @Test

    public void transientIndication_swipeUpToRetry() {

        createController();