Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac651213 authored by Tom Taylor's avatar Tom Taylor
Browse files

Hide unused fields

When ContactHeaderWidget.bindFromPhoneNumber is called with a number
that's not in contacts, onQueryComplete takes a path that doesn't hide
fields that don't apply to the current phone number. As a result, the
user sees the new number, but old data from the previous display (such
as the facebook status). With this change, those fields are hidden.
Fixes bug 2336977.

Change-Id: Ib6253c18dc58c3d28b463c87d5d195a84d613600
parent 08fa1428
Loading
Loading
Loading
Loading
+12 −7
Original line number Diff line number Diff line
@@ -277,6 +277,7 @@ public class ContactHeaderWidget extends FrameLayout implements View.OnClickList
                        } else {
                            String phoneNumber = (String) cookie;
                            setDisplayName(phoneNumber, null);
                            setSocialSnippet(null);
                            mPhotoView.assignContactFromPhone(phoneNumber, true);
                        }
                        break;
@@ -290,6 +291,7 @@ public class ContactHeaderWidget extends FrameLayout implements View.OnClickList
                        } else {
                            String emailAddress = (String) cookie;
                            setDisplayName(emailAddress, null);
                            setSocialSnippet(null);
                            mPhotoView.assignContactFromEmail(emailAddress, true);
                        }
                        break;
@@ -374,6 +376,7 @@ public class ContactHeaderWidget extends FrameLayout implements View.OnClickList
    public void setSocialSnippet(CharSequence snippet) {
        if (snippet == null) {
            mStatusView.setVisibility(View.GONE);
            mStatusAttributionView.setVisibility(View.GONE);
        } else {
            mStatusView.setText(snippet);
            mStatusView.setVisibility(View.VISIBLE);
@@ -446,7 +449,9 @@ public class ContactHeaderWidget extends FrameLayout implements View.OnClickList
     *
     */
    public void wipeClean() {
        setDisplayName(null, null);
        setPhoto(null);
        setSocialSnippet(null);
        mContactUri = null;
        mExcludeMimes = null;
    }