Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac41512d authored by Pablo Gamito's avatar Pablo Gamito
Browse files

Clearly distinguish ProtoLog hash vs message interface 

Flag: android.tracing.perfetto_protolog_tracing
Test: n/a
Change-Id: I64d05752675c5cd0448d6bd50623a3e1ae3e527a
parent 250c03ab

core/java/com/android/internal/protolog/LegacyProtoLogImpl.java

+4 −7
Original line number Diff line number Diff line
@@ -97,12 +97,12 @@ public class LegacyProtoLogImpl implements IProtoLog { 
    @VisibleForTesting

    @Override

    public void log(LogLevel level, IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString, Object[] args) {

            Object[] args) {

        if (group.isLogToProto()) {

            logToProto(messageHash, paramsMask, args);

        }

        if (group.isLogToLogcat()) {

            logToLogcat(group.getTag(), level, messageHash, messageString, args);

            logToLogcat(group.getTag(), level, messageHash, args);

        }

    }
@@ -113,12 +113,9 @@ public class LegacyProtoLogImpl implements IProtoLog { 
                "Not implemented. Only implemented for PerfettoProtoLogImpl.");

    }



    private void logToLogcat(String tag, LogLevel level, long messageHash,

            @Nullable String messageString, Object[] args) {

    private void logToLogcat(String tag, LogLevel level, long messageHash, Object[] args) {

        String message = null;

        if (messageString == null) {

            messageString = mViewerConfig.getViewerString(messageHash);

        }

        final String messageString = mViewerConfig.getViewerString(messageHash);

        if (messageString != null) {

            if (args != null) {

                try {

core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java

+7 −11
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
    @VisibleForTesting

    @Override

    public void log(LogLevel level, IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString, Object[] args) {

            Object[] args) {

        Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "log");



        try {
@@ -180,7 +180,7 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
                        logToProto(level, group, messageHash, paramsMask, args, tsNanos));

            }

            if (group.isLogToLogcat()) {

                logToLogcat(group.getTag(), level, messageHash, messageString, args);

                logToLogcat(group.getTag(), level, messageHash, args);

            }

        } finally {

            Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);
@@ -199,7 +199,7 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
                                tsNanos));

            }

            if (group.isLogToLogcat()) {

                logToLogcat(group.getTag(), logLevel, 0, messageString, args);

                logToLogcat(group.getTag(), logLevel, 0, args);

            }

        } finally {

            Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);
@@ -297,22 +297,18 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
        os.end(outMessagesToken);

    }



    private void logToLogcat(String tag, LogLevel level, long messageHash,

            @Nullable String messageString, Object[] args) {

    private void logToLogcat(String tag, LogLevel level, long messageHash, Object[] args) {

        Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "logToLogcat");

        try {

            doLogToLogcat(tag, level, messageHash, messageString, args);

            doLogToLogcat(tag, level, messageHash, args);

        } finally {

            Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

        }

    }



    private void doLogToLogcat(String tag, LogLevel level, long messageHash,

            @androidx.annotation.Nullable String messageString, Object[] args) {

    private void doLogToLogcat(String tag, LogLevel level, long messageHash, Object[] args) {

        String message = null;

        if (messageString == null) {

            messageString = mViewerConfigReader.getViewerString(messageHash);

        }

        String messageString = mViewerConfigReader.getViewerString(messageHash);

        if (messageString != null) {

            if (args != null) {

                try {

core/java/com/android/internal/protolog/ProtoLogImpl.java

+12 −27
Original line number Diff line number Diff line
@@ -54,48 +54,33 @@ public class ProtoLogImpl { 
    private static Runnable sCacheUpdater;



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void d(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance()

                .log(LogLevel.DEBUG, group, messageHash, paramsMask, messageString, args);

    public static void d(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.DEBUG, group, messageHash, paramsMask, args);

    }



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void v(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance().log(LogLevel.VERBOSE, group, messageHash, paramsMask, messageString,

                args);

    public static void v(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.VERBOSE, group, messageHash, paramsMask, args);

    }



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void i(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance().log(LogLevel.INFO, group, messageHash, paramsMask, messageString, args);

    public static void i(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.INFO, group, messageHash, paramsMask, args);

    }



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void w(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance().log(LogLevel.WARN, group, messageHash, paramsMask, messageString, args);

    public static void w(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.WARN, group, messageHash, paramsMask, args);

    }



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void e(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance()

                .log(LogLevel.ERROR, group, messageHash, paramsMask, messageString, args);

    public static void e(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.ERROR, group, messageHash, paramsMask, args);

    }



    /** Used by the ProtoLogTool, do not call directly - use {@code ProtoLog} class instead. */

    public static void wtf(IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable String messageString,

            Object... args) {

        getSingleInstance().log(LogLevel.WTF, group, messageHash, paramsMask, messageString, args);

    public static void wtf(IProtoLogGroup group, long messageHash, int paramsMask, Object... args) {

        getSingleInstance().log(LogLevel.WTF, group, messageHash, paramsMask, args);

    }



    /**

core/java/com/android/internal/protolog/common/IProtoLog.java

+1 −2
Original line number Diff line number Diff line
@@ -27,11 +27,10 @@ public interface IProtoLog { 
     * @param group The group this message belongs to.

     * @param messageHash The hash of the message.

     * @param paramsMask The parameters mask of the message.

     * @param messageString The message string.

     * @param args The arguments of the message.

     */

    void log(LogLevel logLevel, IProtoLogGroup group, long messageHash, int paramsMask,

             String messageString, Object[] args);

            Object[] args);



    /**

     * Log a ProtoLog message