Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac392735 authored by Wei Wang's avatar Wei Wang
Browse files

Use checkOperation for permission check when starting services. 

noteOperation indicates an operation has been performed, which isn't the case when services are started. For location operations this will cause location icon to show up when the service is started (no location delivery happened yet).

Bug: 125843602
Test: Manual
Change-Id: Ife2e3e415af1f2be4ebfe6fd246ad9afeebb1e28
parent 671c056e

services/core/java/com/android/server/am/ActiveServices.java

+1 −1
Original line number Diff line number Diff line
@@ -2211,7 +2211,7 @@ public final class ActiveServices { 
                return new ServiceLookupResult(null, r.permission);

            } else if (r.permission != null && callingPackage != null) {

                final int opCode = AppOpsManager.permissionToOpCode(r.permission);

                if (opCode != AppOpsManager.OP_NONE && mAm.mAppOpsService.noteOperation(

                if (opCode != AppOpsManager.OP_NONE && mAm.mAppOpsService.checkOperation(

                        opCode, callingUid, callingPackage) != AppOpsManager.MODE_ALLOWED) {

                    Slog.w(TAG, "Appop Denial: Accessing service " + r.shortInstanceName

                            + " from pid=" + callingPid