Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abe54cbf authored Apr 06, 2017 by Felipe Leme

Don't start a partition when session is pending FillResponse authentication.

BUG: 35707731
Test: fixed testFillResponseAuthBothFields and testFillResponseAuthJustOneField

Change-Id: Ib74e46dd37feb7e5c03e40cfbe8133ace6db0709

parent a441da15

services/autofill/java/com/android/server/autofill/Session.java

+7 −0

Original line number	Diff line number	Diff line
		@@ -595,6 +595,13 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
		}

		private ViewState startPartitionLocked(AutofillId id, AutofillValue value) {
		// TODO(b/33197203 , b/35707731): temporary workaround until partitioning supports auth
		if (mResponseWaitingAuth != null) {
		final ViewState viewState =
		new ViewState(this, id, value, this, ViewState.STATE_WAITING_RESPONSE_AUTH);
		mViewStates.put(id, viewState);
		return viewState;
		}
		if (DEBUG) {
		Slog.d(TAG, "Starting partition for view id " + id);
		}

services/autofill/java/com/android/server/autofill/ViewState.java

+2 −0

Original line number	Diff line number	Diff line
		@@ -61,6 +61,8 @@ final class ViewState {
		public static final int STATE_STARTED_PARTITION = 0x20;
		/** User select a dataset in this view, but service must authenticate first. */
		public static final int STATE_WAITING_DATASET_AUTH = 0x40;
		// TODO(b/33197203 , b/35707731): temporary workaround until partitioning supports auth
		public static final int STATE_WAITING_RESPONSE_AUTH = 0x80;

		public final AutofillId id;
		private final Listener mListener;