Commit abdf4850 authored Aug 13, 2019 by TYM Tsai

Protected the null pointer causes cts failed

The current view id is set upon entering and reset to null upon exiting.
The mAssistReceiver may callback after the view exit which caused NPE. To
prevent the symptom, the callback should do nothing when the current view
id is null.

Fixes: 139314597
Fixes: 139349645
Fixes: 139355625
Fixes: 139360077
Test: atest CtsAutoFillServiceTestCases
Test: atest CtsAccessibilityServiceTestCases
Test: atest CtsInputMethodTestCases
Test: atest CtsWidgetTestCases:ToolbarTest

Change-Id: Idbf3c4a24de5547169f905529970e5af795807c2

parent 16397602

services/autofill/java/com/android/server/autofill/Session.java

+5 −0

Original line number	Diff line number	Diff line
		@@ -301,6 +301,11 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
		+ "mForAugmentedAutofillOnly: %s", mForAugmentedAutofillOnly);
		return;
		}
		if (mCurrentViewId == null) {
		Slog.w(TAG, "No current view id - session might have finished");
		return;
		}

		final AssistStructure structure = resultData.getParcelable(ASSIST_KEY_STRUCTURE);
		if (structure == null) {
		Slog.e(TAG, "No assist structure - app might have crashed providing it");