Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab80291c authored by Filip Pavlis's avatar Filip Pavlis
Browse files

Restrict access to AbsListView internals. 

There is in general very low usage of these and they do not seem much
legitimate. Also if there is some customization needed RecyclerView
is the answer. We certainly do not want to start opening these internals.
Please see individual justifications as comments per each item.

Bug: b/123769398
Bug: b/123769710
Bug: b/123768941
Bug: b/123769413
Bug: b/123769379
Test: N/A
Change-Id: I04cacc69612f0693f83fe5caa1cb02490bfb0fcb
parent fe9f8eb8

core/java/android/widget/AbsListView.java

+5 −5
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
     * The data set used to store unused views that should be reused during the next layout

     * to avoid creating new ones

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 123769398)

    final RecycleBin mRecycler = new RecycleBin();



    /**
@@ -421,7 +421,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
     * One of TOUCH_MODE_REST, TOUCH_MODE_DOWN, TOUCH_MODE_TAP, TOUCH_MODE_SCROLL, or

     * TOUCH_MODE_DONE_WAITING

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 123769413)

    int mTouchMode = TOUCH_MODE_REST;



    /**
@@ -632,7 +632,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
    /**

     * Helper object that renders and controls the fast scroll thumb.

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 123768941)

    private FastScroller mFastScroll;



    /**
@@ -698,7 +698,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
    /**

     * Maximum distance to overfling during edge effects

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 123769379)

    int mOverflingDistance;



    // These two EdgeGlows are always set and used together.
@@ -4623,7 +4623,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
     *

     * @param newState The new scroll state.

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 123769710)

    void reportScrollStateChange(int newState) {

        if (newState != mLastScrollState) {

            if (mOnScrollListener != null) {