Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab21b8a8 authored by Jason Chiu's avatar Jason Chiu
Browse files

Fix Settings creating too many threads unexpectedly 

Provide a method to submit a Callable for execution in the shared
background thread pool.

Bug: 143434413
Test: manual, robotest
Change-Id: I149b5926f20acd0e43c4071cc35520c6bc50efef
parent cefcf977

packages/SettingsLib/src/com/android/settingslib/utils/ThreadUtils.java

+18 −5
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settingslib.utils; 
import android.os.Handler;

import android.os.Looper;



import java.util.concurrent.Callable;

import java.util.concurrent.ExecutorService;

import java.util.concurrent.Executors;

import java.util.concurrent.Future;
@@ -64,11 +65,16 @@ public class ThreadUtils { 
     * @Return A future of the task that can be monitored for updates or cancelled.

     */

    public static Future postOnBackgroundThread(Runnable runnable) {

        if (sThreadExecutor == null) {

            sThreadExecutor = Executors.newFixedThreadPool(

                    Runtime.getRuntime().availableProcessors());

        return getThreadExecutor().submit(runnable);

    }

        return sThreadExecutor.submit(runnable);



    /**

     * Posts callable in background using shared background thread pool.

     *

     * @Return A future of the task that can be monitored for updates or cancelled.

     */

    public static Future postOnBackgroundThread(Callable callable) {

        return getThreadExecutor().submit(callable);

    }



    /**
@@ -78,4 +84,11 @@ public class ThreadUtils { 
        getUiThreadHandler().post(runnable);

    }



    private static synchronized ExecutorService getThreadExecutor() {

        if (sThreadExecutor == null) {

            sThreadExecutor = Executors.newFixedThreadPool(

                    Runtime.getRuntime().availableProcessors());

        }

        return sThreadExecutor;

    }

}