Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa78dba2 authored by Felipe Leme's avatar Felipe Leme
Browse files

Renamed flag hsu_behavior_changes to hsu_qs_changes 

The former would be too generic.

Bug: 407061837
Test: build
Flag: EXEMPT renaming flag

Change-Id: I956a54f0c74c7ae63ef3d296d91340f79952b123
parent e10fa405

packages/SystemUI/aconfig/systemui.aconfig

+2 −2
Original line number Diff line number Diff line
@@ -1884,9 +1884,9 @@ flag { 
}



flag {

    name: "hsu_behavior_changes"

    name: "hsu_qs_changes"

    namespace: "systemui"

    description: "Overall changes on Sytem UI when current user is the Headless System User"

    description: "Overall changes on QuickSettings when current user is the Headless System User"

    bug: "408066623"

}

packages/SystemUI/multivalentTests/src/com/android/systemui/qs/panels/ui/viewmodel/EditModeButtonViewModelTest.kt

+4 −4
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ class EditModeButtonViewModelTest : SysuiTestCase() { 
        }



    @Test

    @DisableFlags(Flags.FLAG_HSU_BEHAVIOR_CHANGES)

    @DisableFlags(Flags.FLAG_HSU_QS_CHANGES)

    fun isEditButtonVisibleTrue_nonHsu_flagDisabled() =

        kosmos.runTest {

            val underTest = createEditModeButtonViewModel(false)
@@ -98,7 +98,7 @@ class EditModeButtonViewModelTest : SysuiTestCase() { 
        }



    @Test

    @DisableFlags(Flags.FLAG_HSU_BEHAVIOR_CHANGES)

    @DisableFlags(Flags.FLAG_HSU_QS_CHANGES)

    fun isEditButtonVisibleTrue_hsu_flagDisabled() =

        kosmos.runTest {

            val underTest = createEditModeButtonViewModel(true)
@@ -107,7 +107,7 @@ class EditModeButtonViewModelTest : SysuiTestCase() { 
        }



    @Test

    @EnableFlags(Flags.FLAG_HSU_BEHAVIOR_CHANGES)

    @EnableFlags(Flags.FLAG_HSU_QS_CHANGES)

    fun isEditButtonVisibleTrue_nonHsu_flagEnabled() =

        kosmos.runTest {

            val underTest = createEditModeButtonViewModel(false)
@@ -116,7 +116,7 @@ class EditModeButtonViewModelTest : SysuiTestCase() { 
        }



    @Test

    @EnableFlags(Flags.FLAG_HSU_BEHAVIOR_CHANGES)

    @EnableFlags(Flags.FLAG_HSU_QS_CHANGES)

    fun isEditButtonVisibleFalse_hsu_flagEnabled() =

        kosmos.runTest {

            val underTest = createEditModeButtonViewModel(true)

packages/SystemUI/src/com/android/systemui/qs/panels/ui/viewmodel/toolbar/EditModeButtonViewModel.kt

+2 −2
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ package com.android.systemui.qs.panels.ui.viewmodel.toolbar 


import android.app.ActivityManager

import androidx.compose.runtime.getValue

import com.android.systemui.Flags.hsuBehaviorChanges

import com.android.systemui.Flags.hsuQsChanges

import com.android.systemui.classifier.domain.interactor.FalsingInteractor

import com.android.systemui.lifecycle.ExclusiveActivatable

import com.android.systemui.lifecycle.Hydrator
@@ -62,7 +62,7 @@ constructor( 
            initialValue = false,

            source =

                selectedUserInteractor.selectedUser.map { selectedUserId ->

                    !hsuBehaviorChanges() || !hsum.isHeadlessSystemUser(selectedUserId)

                    !hsuQsChanges() || !hsum.isHeadlessSystemUser(selectedUserId)

                },

        )